Package: globs
Version: 0.2.0~svn50-6
Severity: normal


Could not parse benchmark output:
('  OpenGL 2 not supported!\n',)


Looking at the source code in src/tests/benchmarks/GLSL_parallax/main.c line 
100:

        const GLubyte* string;

...


/* ----- Checking for OpenGL 2 --------------- */
        string = glGetString(GL_VERSION);
        if (string[0] != '2') {
                printf("OpenGL 2 not supported!\n");
                exit(-1);
        }


Which is probably not the proper way of doing it anyway.

https://www.khronos.org/registry/OpenGL-Refpages/gl4/html/glGetString.xhtml

Not to mention glGetString is only available in OpenGL 2.0 and up, so
this check feels completly redundant.

'string ='  is also a risky, as string could be reserved name, and be 0
on errors (i.e. when the GL context creation fails).


Quick fix of course is to do string[0] < '2'


-- System Information:
Debian Release: buster/sid
  APT prefers unstable
  APT policy: (500, 'unstable'), (1, 'experimental')
Architecture: amd64 (x86_64)
Foreign Architectures: i386

Kernel: Linux 4.19.0-2-amd64 (SMP w/32 CPU cores)
Locale: LANG=en_US.UTF-8, LC_CTYPE=en_US.UTF-8 (charmap=UTF-8), 
LANGUAGE=en_US.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /usr/bin/dash
Init: systemd (via /run/systemd/system)
LSM: AppArmor: enabled

Versions of packages globs depends on:
ii  libc6            2.28-8
ii  libgl1           1.1.0-1
ii  libgl1-mesa-glx  19.0.0-1
ii  libsdl-image1.2  1.2.12-10
ii  libsdl1.2debian  1.2.15+dfsg2-4
ii  python           2.7.15-4
ii  python-glade2    2.24.0-5.1+b1

globs recommends no packages.

globs suggests no packages.

-- no debconf information

Reply via email to