Followup-For: Bug #915662
Control: tag -1 patch

Hi,

attached you can find a trivial patch that adds the 'missingok' keyword
to the logrotate config.

Removing system users is nowadays considered bad practice since the
users may still be referenced in the file system or, like in this case,
in configuration files.
I've verified that reinstallation after removal/purge (i.e. with the
user still present) still works.

Please get this fixed and unblocked for buster as it can result in
piuparts regressions (due to the more strict checking we do nowadays).
I might consider NMUing this fix.


Andreas
diff -Nru nagzilla-2.0/debian/changelog nagzilla-2.0/debian/changelog
--- nagzilla-2.0/debian/changelog       2016-01-20 00:14:45.000000000 +0100
+++ nagzilla-2.0/debian/changelog       2019-03-21 11:39:30.000000000 +0100
@@ -1,3 +1,11 @@
+nagzilla (2.0-1.1) UNRELEASED; urgency=medium
+
+  * Non-maintainer upload.
+  * Do not delete the nagzilla user and group after package removal.
+    (Closes: #915662)
+
+ -- Andreas Beckmann <a...@debian.org>  Thu, 21 Mar 2019 11:39:30 +0100
+
 nagzilla (2.0-1) unstable; urgency=medium
 
   * New upstream release, obsoleting patch 05_fix-logrotate-file and
diff -Nru nagzilla-2.0/debian/postrm nagzilla-2.0/debian/postrm
--- nagzilla-2.0/debian/postrm  2016-01-18 21:35:54.000000000 +0100
+++ nagzilla-2.0/debian/postrm  1970-01-01 01:00:00.000000000 +0100
@@ -1,39 +0,0 @@
-#!/bin/sh
-# postrm script for nagzilla
-#
-# see: dh_installdeb(1)
-
-set -e
-
-# summary of how this script can be called:
-#        * <postrm> `remove'
-#        * <postrm> `purge'
-#        * <old-postrm> `upgrade' <new-version>
-#        * <new-postrm> `failed-upgrade' <old-version>
-#        * <new-postrm> `abort-install'
-#        * <new-postrm> `abort-install' <old-version>
-#        * <new-postrm> `abort-upgrade' <old-version>
-#        * <disappearer's-postrm> `disappear' <overwriter>
-#          <overwriter-version>
-# for details, see http://www.debian.org/doc/debian-policy/ or
-# the debian-policy package
-
-
-case "$1" in
-    purge|remove|upgrade|failed-upgrade|abort-install|abort-upgrade|disappear)
-        deluser --quiet --system nagzilla > /dev/null || true
-        delgroup --quiet --system nagzilla > /dev/null || true
-    ;;
-
-    *)
-        echo "postrm called with unknown argument \`$1'" >&2
-        exit 1
-    ;;
-esac
-
-# dh_installdeb will replace this with shell code automatically
-# generated by other debhelper scripts.
-
-#DEBHELPER#
-
-exit 0

Reply via email to