Bug#924967: magnum-common bug in postinst

[Michal Arbet]

Package: magnum-common
Version: 7.1.0-1

Hi,

There is a bug in magnum-common postinst script. Below you can find diff
which is fixing issue.

diff --git a/debian/magnum-common.postinst.in b/debian/
magnum-common.postinst.in
index 0ca43661..46921d94 100644
--- a/debian/magnum-common.postinst.in
+++ b/debian/magnum-common.postinst.in
@@ -108,14 +108,13 @@ create_docker_volume_type () {

                db_get magnum/default_docker_volume_type
                 if [ -n "${RET}" ] ; then
-                       echo "===> magnum-common: Creating cinder volume
type ${RET} ..."
                        # --or-show not working , so we have to do
workaround with show
-                       openstack volume type show ${RET} > /dev/null
-                       if [ $? -ne 0 ]; then
-                               openstack volume type create ${RET}
--description "Cinder volume type used by magnum."
-                       else
-                               echo "===> magnum-common: Cinder volume
type ${RET} already exist."
-                       fi
+                        if ! openstack volume type show ${RET} >
/dev/null; then
+                                echo "===> magnum-common: Creating cinder
volume type ${RET} ..."
+                                openstack volume type create ${RET}
--description "Cinder volume type used by magnum."
+                        else
+                                echo "===> magnum-common: Cinder volume
type ${RET} already exist."
+                        fi
                        pkgos_inifile set ${CONF} cinder
default_docker_volume_type ${RET}
                fi
         fi

Before change postinst was failing with return code 1 if cinder volume type
don't exist.

Thanks,
Michal