Package: release.debian.org
Severity: normal
User: release.debian....@packages.debian.org
Usertags: unblock
Dear RM,
I am asking to unblock onedrive 2.2.6-2 for buster. This is a new
upstream release that fixes a considerable amount of (critical) bugs,
most of which not reported in Debian, but still present. Here are the
release notes from the CHANGELOG.md file:
## 2.2.6 - 2019-03-12
### Fixed
* Resolve application crash when unable to delete remote folders when
business retention policies are enabled
* Resolve deprecation warning: loop index implicitly converted from size_t to
int
* Resolve warnings regarding 'bashisms'
* Resolve handling of notification failure is dbus server has not started or
available
* Resolve handling of response JSON to ensure that 'id' key element is always
checked for
* Resolve excessive & needless logging in monitor mode
* Resolve compiling with LDC on Alpine as musl lacks some standard interfaces
* Resolve notification issues when offline and cannot act on changes
* Resolve Docker entrypoint.sh to accept command line arguments
* Resolve to create a new upload session on reinit
* Resolve where on OneDrive query failure, default root and drive id is used
if a response is not returned
* Resolve Key not found: nextExpectedRanges when attempting session uploads
and incorrect response is returned
* Resolve application crash when re-using an authentication URI twice after
previous --logout
* Resolve creating a folder on a shared personal folder appears successful
but returns a JSON error
* Resolve to treat mv of new file as upload of mv target
* Update Debian i386 build dependencies
* Update handling of --get-O365-drive-id to print out all 'site names' that
match the explicit search entry rather than just the last match
* Update Docker readme & documentation
* Update handling of validating local file permissions for new file uploads
### Added
* Add support for install & uninstall on RHEL / CentOS 6.x
* Add support for when notifications are enabled, display the number of
OneDrive changes to process if any are found
* Add 'config' option 'min_notif_changes' for minimum number of changes to
notify on, default = 5
* Add additional Docker container builds utilising a smaller OS footprint
* Add configurable interval of logging in monitor mode
* Implement new CLI option --skip-dot-files to skip .files and .folders if
option is used
* Implement new CLI option --check-for-nosync to ignore folder when special
file (.nosync) present
* Implement new CLI option --dry-run
The Debian related diffs are trivial, see attached debdiff, where I
excluded the actual code changes in the onedrive sources.
Having 2.2.5 with all the hitherto found bugs in buster would be
unfortunate.
Thanks for your consideration
Norbert
unblock onedrive/2.2.6-2
-- System Information:
Debian Release: buster/sid
APT prefers unstable
APT policy: (500, 'unstable'), (200, 'experimental')
Architecture: amd64 (x86_64)
Foreign Architectures: i386
Kernel: Linux 5.0.2 (SMP w/4 CPU cores)
Kernel taint flags: TAINT_OOT_MODULE, TAINT_UNSIGNED_MODULE
Locale: LANG=en_US.UTF-8, LC_CTYPE=en_US.UTF-8 (charmap=UTF-8),
LANGUAGE=en_US:en (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash
Init: systemd (via /run/systemd/system)
diff -Nru onedrive-2.2.5/debian/changelog onedrive-2.2.6/debian/changelog
--- onedrive-2.2.5/debian/changelog 2019-01-17 11:22:12.000000000 +0900
+++ onedrive-2.2.6/debian/changelog 2019-03-14 07:45:46.000000000 +0900
@@ -1,3 +1,15 @@
+onedrive (2.2.6-2) unstable; urgency=medium
+
+ * upload to unstable
+
+ -- Norbert Preining <norb...@preining.info> Thu, 14 Mar 2019 07:45:46 +0900
+
+onedrive (2.2.6-1) experimental; urgency=medium
+
+ * new upstream release
+
+ -- Norbert Preining <norb...@preining.info> Tue, 12 Mar 2019 17:16:36 +0900
+
onedrive (2.2.5-1) unstable; urgency=medium
* new upstream releases
diff -Nru onedrive-2.2.5/debian/gbp.conf onedrive-2.2.6/debian/gbp.conf
--- onedrive-2.2.5/debian/gbp.conf 2019-01-17 11:22:12.000000000 +0900
+++ onedrive-2.2.6/debian/gbp.conf 2019-03-14 07:45:46.000000000 +0900
@@ -1,5 +1,6 @@
[DEFAULT]
upstream-tag = v%(version)s
+debian-branch = debian
[buildpackage]
debian-branch = debian
diff -Nru onedrive-2.2.5/debian/patches/create-version-from-debian-changelog
onedrive-2.2.6/debian/patches/create-version-from-debian-changelog
--- onedrive-2.2.5/debian/patches/create-version-from-debian-changelog
2019-01-17 11:22:12.000000000 +0900
+++ onedrive-2.2.6/debian/patches/create-version-from-debian-changelog
2019-03-14 07:45:46.000000000 +0900
@@ -1,14 +1,15 @@
---
- Makefile | 4 ++--
- 1 file changed, 2 insertions(+), 2 deletions(-)
+ Makefile | 5 +++--
+ 1 file changed, 3 insertions(+), 2 deletions(-)
--- onedrive.git.orig/Makefile
+++ onedrive.git/Makefile
-@@ -109,5 +109,5 @@ endif
+@@ -126,5 +126,6 @@ endif
for i in $(DOCFILES) ; do rm -f $(DESTDIR)$(DOCDIR)/$$i ; done
rm -f $(DESTDIR)$(MANDIR)/onedrive.1
-version: .git/HEAD .git/index
-- echo $(shell git describe --tags) >version
+- echo $(shell git describe --tags) > version
+version: debian/changelog
+ echo v$(shell dpkg-parsechangelog -S version) > version
++
diff -Nru onedrive-2.2.5/debian/patches/fix-install-location
onedrive-2.2.6/debian/patches/fix-install-location
--- onedrive-2.2.5/debian/patches/fix-install-location 2019-01-17
11:22:12.000000000 +0900
+++ onedrive-2.2.6/debian/patches/fix-install-location 2019-03-14
07:45:46.000000000 +0900
@@ -4,7 +4,7 @@
--- onedrive.git.orig/Makefile
+++ onedrive.git/Makefile
-@@ -25,7 +25,7 @@ endif
+@@ -28,7 +28,7 @@ endif
DFLAGS += -w -g -ofonedrive -O $(NOTIF_VERSIONS) $(LIBS) -J.
diff -Nru onedrive-2.2.5/debian/patches/fix-systemd-service-install-location
onedrive-2.2.6/debian/patches/fix-systemd-service-install-location
--- onedrive-2.2.5/debian/patches/fix-systemd-service-install-location
2019-01-17 11:22:12.000000000 +0900
+++ onedrive-2.2.6/debian/patches/fix-systemd-service-install-location
2019-03-14 07:45:46.000000000 +0900
@@ -5,7 +5,7 @@
--- onedrive.git.orig/Makefile
+++ onedrive.git/Makefile
-@@ -83,10 +83,10 @@ else
+@@ -95,10 +95,10 @@ else
chown root.root $(DESTDIR)/usr/lib/systemd/user/
chmod 0755 $(DESTDIR)/usr/lib/systemd/user/
install -D -m 644 onedrive.service $(DESTDIR)/usr/lib/systemd/user/
@@ -17,6 +17,6 @@
+ chown root.root $(DESTDIR)/lib/systemd/system/
+ chmod 0755 $(DESTDIR)/lib/systemd/system/
+ install -D -m 644 onedrive@.service $(DESTDIR)/lib/systemd/system/
- endif
install -D -m 644 onedrive.service
$(DESTDIR)/usr/lib/systemd/user/onedrive.service
+ endif
diff -Nru onedrive-2.2.5/debian/rules onedrive-2.2.6/debian/rules
--- onedrive-2.2.5/debian/rules 2019-01-17 11:22:12.000000000 +0900
+++ onedrive-2.2.6/debian/rules 2019-03-14 07:45:46.000000000 +0900
@@ -4,6 +4,6 @@
dh $@
override_dh_auto_build:
- make DC=ldmd2 NOTIFICATIONS=1
+ make DC=ldc2 NOTIFICATIONS=1 PKGCONFIG=1
chrpath --delete onedrive
