Control: tag -1 patch

On 3/10/19 9:32 PM, Arnaud Rebillout wrote:

>>
>> As far as I understand the packaging, it seems that all of them could be 
>> easily added to
>> https://sources.debian.org/src/docker.io/18.09.1+dfsg1-5/debian/golang-github-docker-docker-dev.install
>>
>> Is this assumption right? Are there compelling reasons against doing that?
> 
> I think you're correct, you should give it a try, and if it works feel
> free to commit on the docker.io salsa repo.
> [...]

Hi Arnaud,

thank you very much for your detailed explanation, while surprising, it does 
help with the understanding of this source package significantly.

I've implemented the change and confirmed that the attached patch does allow 
github.com/openstack/imagebuilder to be built successfully. As suggested, I've 
tried to push to salsa, but it seems I'm not permissioned to do so (docker.io 
is not under the go-team umbrella):

  $ git push 
  GitLab: You are not allowed to push code to this project.
  fatal: Could not read from remote repository.

Would you be able to upload the patch to experimental anytime soon? If it 
helped, I'd be happy to upload this patch as an NMU to experimental myself. 
Please let me know what works for you best.

Cheers,
-rt
From 4abbd5b15e0735443cf8ad54165ab054dcab6f14 Mon Sep 17 00:00:00 2001
From: Reinhard Tartler <siret...@tauware.de>
Date: Tue, 12 Mar 2019 18:53:36 -0400
Subject: [PATCH] github-golang-docker-docker-dev: add missing sources

While working on the package 'golang-github-openshift-imagebuilder', it
turns out that some sources that are contained in the docker.io source
package were left out at installation time. This commit includes
some sources that allow golang-github-openshift-imagebuilder to be
built.

Closes: #924257
---
 debian/golang-github-docker-docker-dev.install | 9 +++++++++
 1 file changed, 9 insertions(+)

diff --git a/debian/golang-github-docker-docker-dev.install b/debian/golang-github-docker-docker-dev.install
index b5cdcebe..fc6c5861 100644
--- a/debian/golang-github-docker-docker-dev.install
+++ b/debian/golang-github-docker-docker-dev.install
@@ -11,9 +11,12 @@
 ## Engine
 engine/dockerversion                                usr/share/gocode/src/github.com/docker/docker/
 .gopath/src/github.com/docker/docker/api            usr/share/gocode/src/github.com/docker/docker/
+.gopath/src/github.com/docker/docker/builder        usr/share/gocode/src/github.com/docker/docker/
 .gopath/src/github.com/docker/docker/cli            usr/share/gocode/src/github.com/docker/docker/
 .gopath/src/github.com/docker/docker/client         usr/share/gocode/src/github.com/docker/docker/
+.gopath/src/github.com/docker/docker/container      usr/share/gocode/src/github.com/docker/docker/
 .gopath/src/github.com/docker/docker/errdefs        usr/share/gocode/src/github.com/docker/docker/
+.gopath/src/github.com/docker/docker/image          usr/share/gocode/src/github.com/docker/docker/
 .gopath/src/github.com/docker/docker/opts           usr/share/gocode/src/github.com/docker/docker/
 .gopath/src/github.com/docker/docker/pkg            usr/share/gocode/src/github.com/docker/docker/
 .gopath/src/github.com/docker/docker/reference      usr/share/gocode/src/github.com/docker/docker/
@@ -31,6 +34,10 @@ engine/dockerversion                                usr/share/gocode/src/github.
 .gopath/src/github.com/docker/libnetwork/types            usr/share/gocode/src/github.com/docker/libnetwork/
 
 
+## go-metrics
+.gopath/src/github.com/docker/go-metrics        usr/share/gocode/src/github.com/docker/go-metrics
+
+
 ## Sub-vendoring:
 engine/vendor/github.com/containerd/continuity/driver        usr/share/gocode/src/github.com/docker/docker/vendor/github.com/containerd/continuity/
 engine/vendor/github.com/containerd/continuity/pathdriver    usr/share/gocode/src/github.com/docker/docker/vendor/github.com/containerd/continuity/
@@ -39,3 +46,5 @@ engine/vendor/github.com/Nvveen/Gotty                        usr/share/gocode/sr
 
 distribution/reference                                       usr/share/gocode/src/github.com/docker/docker/vendor/github.com/docker/distribution/
 distribution/digestset                                       usr/share/gocode/src/github.com/docker/docker/vendor/github.com/docker/distribution/
+
+cli/vendor/github.com/moby/buildkit/                         usr/share/gocode/src/github.com/moby/
-- 
2.11.0

Reply via email to