Package: dh-golang
Severity: normal

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA512

Usually we pass extra test flags like this

```
override_dh_auto_test:
        dh_auto_test -- -myflag balabala
```

And expect the extra flags are consumed by `go test` command.

dh-golang construct the `go test` with:

```
$this->doit_in_builddir("go", "test", "-vet=off", "-v", @_, get_targets());
```

`@_` is before `get_targets()`.


However from the doc(`go test -h`),

> The command-line package list, if present, must appear before any
> flag not known to the go test command. Continuing the example above,
> the package list would have to appear before -myflag, but could appear
> on either side of -v.

This means we can't pass any custom flag to go test.

I would suggest dh-golang to construct command with:

```
"go", "test", "-vet=off", "-v", get_targets(), @_)
```

IIUC, this won't break anything.

- --
Shengjing Zhu

-----BEGIN PGP SIGNATURE-----

iQFEBAEBCgAuFiEE85F2DZP0aJKsSKyHONAPABi+PjUFAlyDq9kQHHpoc2pAZGVi
aWFuLm9yZwAKCRA40A8AGL4+NXD5B/4/Va6IWfeVzJEXjnkVNCdSNqSE8s4n1tn6
s0l+D/thqbbWx64dafROKl2wsBFfgvzBeS0zn222wmLAssFBHCVpn1oJFi2D4r28
esUgK4681ZARhUcM8OcVwxWoMoT069ZNJX8AwQtDlOPfvRBRBiKCOz4UljlC5Cac
j7Pq8h6uMeAoLHOeBwI9PGKvhOPmmsSSUrCQ7YN6amUam8qmJ6yL8HGHLB9VR4x+
hYqhuIZSCblGS96cqE4/fJfGnPaQIMKoXL1kzmBqwnKUvK127zcwk9nceRpZFGft
PINE64nXXOAaGx0IuakhvleTz2OLI5rDY3vKfMZvaDt9IVt22UrZ
=ioBi
-----END PGP SIGNATURE-----

Reply via email to