On Mon, 10 Dec 2018 16:29:02 -0500 Dean Serenevy <d...@serenevy.net> wrote: > Package: network-manager-gnome > Version: 1.8.18-2 > Severity: normal > > Dear Maintainer, > > Hello, it seems that upstream changes have broken part of > Allow-to-create-connections-without-admin-privileges.patch (written to > address bug 696256). > > Upstream commit 0c92debe9 marks all WiFi connections as user > connections by default, where the Debian patch checks whether the user > has the org.freedesktop.NetworkManager.settings.modify.system > permission and only creates a user connection if the permission check > fails. > > Unfortunately, the user vs system connection issue has a lot of > history and the default behavior seems to bounce around as different > use situations are emphasized. The nice thing about the Debian patch > is that it solves the problem for multiple use cases, any user in the > netdev group creates system connections, other users create user-only > connections. > > I've attached a patch which could be rolled into > Allow-to-create-connections-without-admin-privileges.patch to restore > the functionality of that patch. It simply removes the line added by > upstream which unconditionally marks the connection as a user > connection, allowing the Debian logic to apply. The other alternative, > of course, is to remove that patch (entirely or in part) and continue > using the upstream behavior. > > Our particular usage situation requires less-technical users to create > a network connecction for system use, so being able to create system > connections by default significantly eases the burden of our support > staff. If connections are not system-wide by default, we have to walk > each user through the process of checking the "All users may connect > to this netowrk" box. Therefore, we would definitely prefer that the > patch be updated rather than just removed.
Thanks for your patch. I'll include it for buster. In buster +1 I can imagine that we eventually drop our Debian specific patch. It has been a pain to keep it updated over the years and I'll try to reduce the diff to upstream. Regards, Michael -- Why is it that all of the instruments seeking intelligent life in the universe are pointed away from Earth?
signature.asc
Description: OpenPGP digital signature
