Package: watchdog
Version: 5.15-2
Severity: normal

I've noticed it due to needrestart, but even on manual invocations
restarting the watchdog service (systemctl restart watchdog.service)
_always_ fails.  The service status after a failed restart looks like this:

● watchdog.service - watchdog daemon
   Loaded: loaded (/lib/systemd/system/watchdog.service; enabled; vendor 
preset: enabled)
   Active: inactive (dead) since Mon 2019-02-25 09:32:15 EST; 3s ago
  Process: 30341 ExecStartPre=/bin/sh -c [ -z "${watchdog_module}" ] || [ 
"${watchdog_module}" = "none" ] || /sbin/modprobe $watchdog_module 
(code=exited, status=0/SUCCESS)
  Process: 30342 ExecStart=/bin/sh -c [ $run_watchdog != 1 ] || exec 
/usr/sbin/watchdog $watchdog_options (code=exited, status=0/SUCCESS)
  Process: 30348 ExecStopPost=/bin/sh -c [ $run_wd_keepalive != 1 ] || false 
(code=exited, status=1/FAILURE)
 Main PID: 30344 (code=exited, status=0/SUCCESS)

This is reproducible on multiple machines for me.

The shell snippet under ExecStopPost is suspicious to me, as the construct
it uses will _always_ fail.  It looks like it's meant to make the service
stop fail so as to trigger the wd_keepalive service.  The wd_keepalive
service settings have an ExecStartPre that looks like it's supposed to clear
this failed state, but it doesn't seem to work properly.  Either way the
"always fail on stop" nature makes restarting the watchdog service normally
impossible, which is not good.

-- System Information:
Debian Release: buster/sid
  APT prefers testing
  APT policy: (990, 'testing'), (500, 'testing-debug'), (500, 'stable'), (500, 
'oldstable'), (490, 'unstable'), (1, 'experimental')
Architecture: amd64 (x86_64)

Kernel: Linux 4.20.0-trunk-amd64 (SMP w/16 CPU cores)
Locale: LANG=en_US.UTF-8, LC_CTYPE=en_US.UTF-8 (charmap=UTF-8), 
LANGUAGE=en_US.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash
Init: systemd (via /run/systemd/system)

Versions of packages watchdog depends on:
ii  debconf [debconf-2.0]  1.5.70
ii  init-system-helpers    1.56+nmu1
ii  libc6                  2.28-7
ii  lsb-base               10.2018112800
ii  makedev                2.3.1-94
ii  udev                   240-6

watchdog recommends no packages.

watchdog suggests no packages.

-- Configuration Files:
/etc/default/watchdog changed:
run_watchdog=1
run_wd_keepalive=1
watchdog_module="iTCO_wdt"
watchdog_options=""

/etc/watchdog.conf changed:
realtime                = yes
priority                = 1
file = /var/log/total
change = 600


-- debconf information:
* watchdog/run: true
* watchdog/run_keepalive: true
* watchdog/restart: true
* watchdog/module: iTCO_wdt

Reply via email to