On Sun, 2019-02-17 at 23:45:37 +0100, Chris Lamb wrote: > Do others have thoughts before I apply this patch?
As I mentioned initially, I don't think the patch is ready as is, it even has syntax errors (at least one ‘?‘ :). It would probably need a new pass over the newly created tags, a review of the proposed ones, and fixing up the description and tag emissions to use the new names. Also the new (and old) tags do not seem that uniform after all, because I also noticed inconsistencies in their form, I'd say most use a form such as subject-verb-object/adjective, but then others use forms such as adjective-object-adverb-subject, so it might make sense to try to unify that too, perhaps, if we are going to do a mass cleanup? :) Thanks, Guillem
