Hello, "Gabriel F. T. Gomes" <gabr...@inconstante.net.br> wrote:
> I updated the merge request. > > When I first wrote the merge request, upstream did not have a fix for > the METAR problem. Now they do [1]. So, I removed the simple patch I > wrote, and replaced it with this upstream fix. (...) > [1] > https://sourceforge.net/p/flightgear/flightgear/ci/2fdc24c1097955c5d2c88a9cc0be66069b22eebe/ As has been discussed on flightgear-devel and despite the commit message, commit [1] is not a proper fix and will probably be reverted (I mean, the "if( responseCode() >= 400 )" part, not the http to https URL change which is okay though unnecessary now that redirection is fixed in SimGear's HTTP::Client). The correct fix is [a]. [b] is also a bug fix in this area, but doesn't solve the particular METAR fetching problem. [a] https://sourceforge.net/p/flightgear/simgear/ci/34b3c52a288d62779073fc7694344d0658755645/ [b] https://sourceforge.net/p/flightgear/simgear/ci/6197098541eceecdb0dcfe8a58b15f0d0773c391/ -- Florent
