On Fri, Feb 01, 2019 at 12:13:05PM -0800, John Horigan wrote: > There are several more template symbols besides those two. Shouldn't they > all be marked as optional? This is my first time generating a package with > a symbols file.
It is reasonable to mark any template symbols as optional, my patch is merely the minimal change necessary to let the package build successfully on ppc64el in Ubuntu. Cheers, -- Steve Langasek Give me a lever long enough and a Free OS Debian Developer to set it on, and I can move the world. Ubuntu Developer https://www.debian.org/ slanga...@ubuntu.com vor...@debian.org > On Fri, Feb 1, 2019 at 9:03 AM Steve Langasek <steve.langa...@canonical.com> > wrote: > > > Package: agg > > Version: 1:2.6.0-r132+dfsg1-2 > > Severity: minor > > Tags: patch > > User: ubuntu-de...@lists.ubuntu.com > > Usertags: origin-ubuntu disco ubuntu-patch > > > > Hi John, > > > > The latest version of agg, 1:2.6.0-r132+dfsg1-2, fails to build from source > > on ppc64el in Ubuntu due to a difference in the symbols output for the > > shared library. This is because Ubuntu defaults to -O3 on ppc64el, which > > means some additional template symbols are omitted from the output that are > > otherwise seen when building with -O2. > > > > Since these are template symbols and not part of the shared library ABI, a > > correct fix to make the library compatible with -O3 is to mark these > > symbols > > optional as in the attached patch. Please consider applying in Debian. > > > > Thanks, > > -- > > Steve Langasek Give me a lever long enough and a Free OS > > Debian Developer to set it on, and I can move the world. > > Ubuntu Developer https://www.debian.org/ > > slanga...@ubuntu.com vor...@debian.org > >
signature.asc
Description: PGP signature
