Subject: flashplugin-nonfree: please use /var/tmp instead of /var/run
Package: flashplugin-nonfree
Version: 7.0.63.1
Severity: normal
Tags: patch

/usr/sbin/update-flashplugin seems to use /var/run/flashplugin-nonfree
as directory to download and unpack the plugin. Since this directory is
generally used to store small run-time data [1] I (and several other
people) have /var/run mounted as a tmpfs filesystem.

The attached patch uses mktemp to create a temporary directory in the
default /tmp directory (which can be set by the TMPDIR environment
variable).

[1] http://www.pathname.com/fhs/pub/fhs-2.3.html#VARRUNRUNTIMEVARIABLEDATA

-- System Information:
Debian Release: testing/unstable
  APT prefers unstable
  APT policy: (500, 'unstable'), (1, 'experimental')
Architecture: i386 (i686)
Shell:  /bin/sh linked to /bin/bash
Kernel: Linux 2.6.15.1-spiritus
Locale: LANG=en_US, LC_CTYPE=en_US (charmap=ISO-8859-1)

Versions of packages flashplugin-nonfree depends on:
ii  debconf [debconf-2.0]         1.4.72     Debian configuration management sy
ii  gsfonts-x11                   0.18       Make Ghostscript fonts available t

Versions of packages flashplugin-nonfree recommends:
ii  libstdc++2.10-glibc2.2       1:2.95.4-24 The GNU stdc++ library

-- debconf information:
  flashplugin-nonfree/httpget: true
  flashplugin-nonfree/not_exist:
  flashplugin-nonfree/http_proxy:
  flashplugin-nonfree/failed:
  flashplugin-nonfree/local:
  flashplugin-nonfree/delete: false

-- 
-- arthur - [EMAIL PROTECTED] - http://people.debian.org/~adejong --
--- /root/update-flashplugin.orig	2006-03-17 22:13:13.000000000 +0100
+++ /usr/sbin/update-flashplugin	2006-03-17 22:19:19.000000000 +0100
@@ -74,17 +74,16 @@
 
 	"install")
 
-		rm -rf /var/run/flashplugin-nonfree
-		mkdir /var/run/flashplugin-nonfree
-		cd /var/run/flashplugin-nonfree
+		TMPDIR=`mktemp -d flashplugin-nonfree.XXXXXX`
+		cd "$TMPDIR"
 		FAIL="false"
 
 		if [ $WITHLOCALFILE = "true" ]; then
 
-			cp $LOCALFILE /var/run/flashplugin-nonfree || FAIL="true"
+			cp $LOCALFILE "$TMPDIR" || FAIL="true"
 			if [ $FAIL = "true" ]; then
 				echo "cannot copy local file: $LOCALFILE"
-				rm -rf /var/run/flashplugin-nonfree
+				rm -rf "$TMPDIR"
 				exit -1
 			fi
 
@@ -133,7 +132,7 @@
 			# failed
 			if [ $FAIL = "true" ]; then
 				echo "automatic installation failed due to network problems or upstream changes"
-				rm -rf /var/run/flashplugin-nonfree
+				rm -rf "$TMPDIR"
 				exit -1
 			fi
 
@@ -144,7 +143,7 @@
 			tar xzf install_flash_player_7_linux.tar.gz || FAIL="true"
 			if [ $FAIL = "true" ]; then
 				echo "cannot unpack plugin"
-				rm -rf /var/run/flashplugin-nonfree
+				rm -rf "$TMPDIR"
 				exit -1
 			fi
 		fi
@@ -153,7 +152,7 @@
 			echo "37b8b6030388d23eeb8150eb67ad063e  install_flash_player_7_linux/libflashplayer.so"| md5sum -c > /dev/null 2>&1 || FAIL="true"
 			if [ $FAIL = "true" ]; then
 				echo "plugin changed, not trusted"
-				rm -rf /var/run/flashplugin-nonfree
+				rm -rf "$TMPDIR"
 				exit -1
 			fi
 		fi
@@ -178,7 +177,7 @@
 			mksymlink /usr/lib/flashplugin-nonfree/flashplayer.xpt   /usr/lib/firefox/plugins/flashplayer.xpt || FAIL="true"
 			if [ $FAIL = "true" ]; then
 				echo "installation failed"
-				rm -rf /var/run/flashplugin-nonfree
+				rm -rf "$TMPDIR"
 				uninstall_plugin # cleanup failed install
 				exit -1
 			fi
@@ -186,7 +185,7 @@
 
 		# cleaning up
 		cd /
-		rm -rf /var/run/flashplugin-nonfree
+		rm -rf "$TMPDIR"
 
 		# Chrome update
 		if [ -x /usr/sbin/update-mozilla-chrome ]; then

Attachment: signature.asc
Description: This is a digitally signed message part

Reply via email to