[CC-ing Xavier in case he has missed this conversation] > * 0016-Move-all-parsing-of-configuration-files-to-a-separat.patch (and let-uscan-use-confvar.patch)
Devscripts::Confvar answers the needs of all 25 existing Perl or Shell scripts. For each one, I have checked that settings in ~/.devscripts.conf are reflected by --help. The devscripts test suite is extended to check each function of the module with variables containing various escaped characters. Independently, Xavier has created Devscripts::Config. This module is part of refactoring uscan.pl, and is only tested with it. It has been merged and released. Contributors updating or creating scripts will rightfully use it, as it is designed with generality in mind. This will increase the divergence and make the merge of features and ideas harder and harder. I would quite like an explicit list of requirements for Devscripts::Confvar to be considered too. Rebasing it again and again is boring, error-prone, and a complete waste of time as long as no one reviews it. > 0012-Improve-reporting-of-noconf-misusage.patch > Also. I want to check how the documentation around those options is. I have written this patch exactly by comparing for each script the output of --help with the actual option handling. I have then run each one with --usage, and checked the no-conf part. What else can make you feel confident about the change? > * 0011-Set-e-option-for-some-shell-scripts.patch > I'll wait till have some more time before merging this one I have looked for deliberately ignored errors in the whole source of each script. Of course, more reviewers would be welcome. How many? What else can make you feel confident about the change?
