Hi Piotr and Faidon, On Thu, 10 Jan 2019 18:31:01 +0100 Johannes Schauer <jo...@debian.org> wrote: > Quoting Faidon Liambotis (2019-01-10 15:29:59) > > Unfortunately, the initialization code runs regardless of whether prof was > > enabled or not, and from the code it seems like this is intentional... > > > > See here: > > https://github.com/jemalloc/jemalloc/blob/5.1.0/src/prof.c#L2392 > > ...where the relevant call to _Unwind_Backtrace is outside the "if > > (opt_prof) > > { }" block. (The code is similar in the dev branch) > > then I guess the proper fix would be to adapt dl_iterate_phdr to act > differently in case libjemalloc.so is loaded? > > I fear I lack the knowledge of how to do that and unless Piotr finds some > time, > I guess the best we can do for Buster, is to temporarily disable the test and > declare that jemalloc and fakechroot are incompatible in Buster. :/
since nobody else stepped up to fix this properly, I now uploaded a NMU that just disables the failing test. As per devref recommendation I uploaded it to DELAYED/2. Debdiff is attached. Thanks! cheers, josch
diff -Nru fakechroot-2.19/debian/changelog fakechroot-2.19/debian/changelog --- fakechroot-2.19/debian/changelog 2019-01-01 08:05:21.000000000 +0100 +++ fakechroot-2.19/debian/changelog 2019-01-27 16:34:19.000000000 +0100 @@ -1,3 +1,13 @@ +fakechroot (2.19-3.2) unstable; urgency=medium + + * Non-maintainer upload. + * Build-Depends on libjemalloc-dev instead of libjemalloc1 (closes: #918741) + * Disable jemalloc test because since libjemalloc2, fakechroot is + incompatible with jemalloc. They must not be preloaded at the same time. + (closes: #918742) + + -- Johannes 'josch' Schauer <jo...@debian.org> Sun, 27 Jan 2019 16:34:19 +0100 + fakechroot (2.19-3.1) unstable; urgency=medium * Non-maintainer upload. diff -Nru fakechroot-2.19/debian/control fakechroot-2.19/debian/control --- fakechroot-2.19/debian/control 2016-11-20 18:23:16.000000000 +0100 +++ fakechroot-2.19/debian/control 2019-01-27 16:25:54.000000000 +0100 @@ -6,7 +6,7 @@ debhelper (>= 9.20141010), dh-autoreconf, dpkg-dev (>= 1.17.14), - libjemalloc1 <!nocheck> + libjemalloc-dev <!nocheck> Standards-Version: 3.9.8 Homepage: https://github.com/dex4er/fakechroot VCS-Git: https://anonscm.debian.org/git/collab-maint/fakechroot.git diff -Nru fakechroot-2.19/debian/patches/disable-jemalloc-test fakechroot-2.19/debian/patches/disable-jemalloc-test --- fakechroot-2.19/debian/patches/disable-jemalloc-test 1970-01-01 01:00:00.000000000 +0100 +++ fakechroot-2.19/debian/patches/disable-jemalloc-test 2019-01-27 16:29:27.000000000 +0100 @@ -0,0 +1,12 @@ +--- a/test/t/jemalloc.t ++++ b/test/t/jemalloc.t +@@ -9,6 +9,9 @@ libjemalloc=` + done + echo no + ` ++# temporarily disable ++# https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=918742 ++libjemalloc=no + test $libjemalloc = "no" && skip_all 'jemalloc library is missing (sudo apt-get install libjemalloc1)' + + prepare 1 diff -Nru fakechroot-2.19/debian/patches/series fakechroot-2.19/debian/patches/series --- fakechroot-2.19/debian/patches/series 2019-01-01 08:05:21.000000000 +0100 +++ fakechroot-2.19/debian/patches/series 2019-01-27 16:28:35.000000000 +0100 @@ -1 +1,2 @@ renameat2.patch +disable-jemalloc-test
signature.asc
Description: signature
