Source: libantlr3c
Version: 3.4+dfsg-2
Severity: serious
Justification: policy 4.6
Tags: patch
libantlr3c fails to cross build from source, because it does not pass
--host to ./configure. The easiest way of doing so is using
dh_auto_configure. That is sufficient for making libantlr3c cross
buildable.
While preparing the patch, I noticed that debian/rules is chaining build
command (configure and ln) with ";". Doing so is prohibited by Debian
policy section 4.6, because it can result in silent misbuilds.
Therefore, I bumped the severity to serious.
The attached patch fixes both issues as they really affect the same
lines. Merging these issues felt simpler that filing two bugs with
conflicting patches.
Helmut
diff --minimal -Nru libantlr3c-3.4+dfsg/debian/changelog
libantlr3c-3.4+dfsg/debian/changelog
--- libantlr3c-3.4+dfsg/debian/changelog 2018-06-21 12:38:06.000000000
+0200
+++ libantlr3c-3.4+dfsg/debian/changelog 2019-01-25 06:33:12.000000000
+0100
@@ -1,3 +1,10 @@
+libantlr3c (3.4+dfsg-2.1) UNRELEASED; urgency=medium
+
+ * Non-maintainer upload.
+ * Use dh_auto_configure. (Closes: #-1)
+
+ -- Helmut Grohne <hel...@subdivi.de> Fri, 25 Jan 2019 06:33:12 +0100
+
libantlr3c (3.4+dfsg-2) unstable; urgency=medium
* QA upload.
diff --minimal -Nru libantlr3c-3.4+dfsg/debian/rules
libantlr3c-3.4+dfsg/debian/rules
--- libantlr3c-3.4+dfsg/debian/rules 2018-06-16 22:18:36.000000000 +0200
+++ libantlr3c-3.4+dfsg/debian/rules 2019-01-25 06:33:10.000000000 +0100
@@ -16,22 +16,16 @@
override_dh_auto_configure:
# Configure with ANTLR remote debugger enabled
- mkdir build-dbg
- ( cd build-dbg; \
- ../configure $(CROSS) --prefix=/usr \
- --libdir=\$${prefix}/lib/$(DEB_HOST_MULTIARCH) \
+ dh_auto_configure --builddirectory=build-dbg --
--enable-debuginfo --disable-abiflags --enable-antlrdebug \
- $(ENABLE_64BIT); \
- ln -s ../include )
+ $(ENABLE_64BIT)
+ ln -s ../include build-dbg/
# Configure with ANTLR remote debugger disabled
- mkdir build-nodbg
- ( cd build-nodbg; \
- ../configure $(CROSS) --prefix=/usr \
- --libdir=\$${prefix}/lib/$(DEB_HOST_MULTIARCH) \
+ dh_auto_configure --builddirectory=build-nodbg --
--enable-debuginfo --disable-abiflags --disable-antlrdebug \
- $(ENABLE_64BIT); \
- ln -s ../include )
+ $(ENABLE_64BIT)
+ ln -s ../include build-nodbg/
override_dh_auto_build:
( cd build-dbg; $(MAKE) )
