On Sun, Jan 13, 2019 at 11:34:31PM +0000, Colin Watson wrote:
> On Thu, Jan 10, 2019 at 01:19:27PM +0100, Stefan Agner wrote:
> > Using update-binfmts with the same magic and fix-binary twice, will
> > install the detector on the second call. However, this breaks fix-binary
> > since the whole point of fixed binary is to allow to use the interpreter
> > inside a container/chroot. If a detector is in the play, this detector
> > won't be able to load the interpreter from inside the container/chroot.
> > 
> > I think it would be more sensible for binfmt-support to warn the user on
> > the second invocation.
> 
> This is a good point, thanks.  I think your patch adds the warning in
> slightly the wrong place, though, as it misses the case where a detector
> is requested explicitly (e.g. using --detector), which has essentially
> the same problem.  We should probably also document the situation.
> 
> What do you think of the attached patch against upstream master?

I've gone ahead and pushed this to master.

Thanks,

-- 
Colin Watson                                       [cjwat...@debian.org]

Reply via email to