Hi Santiago, Thanks for the patch.
On Saturday, 5 January 2019 10:43:14 AM AEDT Santiago Vila wrote:
> ## #916415
> - timeout 11 ./nocache apt show coreutils 1>>/dev/null
> + timeout 60 ./nocache apt show coreutils 1>>/dev/null
I see, this issue is environment specific and seems to fail on sloe(er)
machines like MIPS.
> Note: I don't quite understand the purpose of the timeout. Is it
> really useful/required to set a timeout at all?
In this case it is _necessary_. As you could notice from comment, this is a
regression test for #916415. Timeout is required because process never exit
(hangs) when test fails.
> Normally sbuild (the
> autobuilder program used by the build daemons) has already a built-in
> timeout mechanism which prevents the autobuilder to be stuck forever,
> and by looking at build logs from reproducible builds, I believe
> pbuilder has also a timeout by default.
Timeout here is to abort a particular test if/when it fails. It is better to
fail quickly (within a minute) rather than needlessly occupy builder for an
hour.
--
Cheers,
Dmitry Smirnov.
---
A man does what he must - in spite of personal consequences, in spite of
obstacles and dangers and pressures - and that is the basis of all human
morality.
-- Winston Churchill
signature.asc
Description: This is a digitally signed message part.
