Sean,
On Sat, Jan 5, 2019 at 12:18 PM Sean Whitton <spwhit...@spwhitton.name> wrote:
>
> [Please use X-debbugs-cc: rather than Cc: when you want a new bug to be
> copied to someone else. I had to look up the bug number in order to be
> able to reply.]
Sorry, wasn't thinking. I added your name at the last moment.
> Hello Paul,
>
> Thank you for your interest. Here is a review of the patch.
>
> On Sat 05 Jan 2019 at 09:19am -0800, Paul Hardy wrote:
>
> > dgit clone needs to be told the source package name
> > -(which might be different to the binary package name,
> > +(which might be different from the binary package name,
>
> Aren't either acceptable in contemporary English? ('to' is what I would
> expect myself to write)
I'm accustomed to "different from", but I am not a grammarian. :-)
Whichever you prefer.
> > @@ -355,7 +355,7 @@ in .git/info/attributes,
> > but it is insufficient,
> > because it was made by an earlier version of dgit
> > and git has since introduced new transforming attributes,
> > -modifies the macro to disable the newer transformations.
> > +this modifies the macro to disable the newer transformations.
>
> I think the comma just before your change now needs to be a semicolon.
Yes, it does. I missed that.
> > -the latter unless the former exists on PATH.)
> > +the latter unless the former exists in PATH.)
>
> This is wrong. "in PATH" suggests actually present in the string PATH;
> "on PATH" means in one of the directories specified by PATH, AFAIK.
Okay.
> > -Whether to setup a merge driver which uses dpkg-mergechangelogs for
> > +Whether to set up a merge driver which uses dpkg-mergechangelogs for
>
> I think this is wrong. AIUI, 'setup' is a noun and 'set up' is a verb.
Right, so it seemed it was being used as a verb; hence "set up". One
way or another, everybody will know what is meant of course.
All the best,
Paul Hardy
