Hi.

For your consideration: The following patch works for me (but I don't
know anything about Go, please double-check).

As I said in my initial report, unit tests are mostly useful when they
test the package which is being built, but this one checks the underlying
system, not the package itself, which is a little bit odd and not so useful.

Thanks.
diff -Nru golang-golang-x-sys-0.0~git20181228.9a3f9b0/debian/changelog 
golang-golang-x-sys-0.0~git20181228.9a3f9b0/debian/changelog
--- golang-golang-x-sys-0.0~git20181228.9a3f9b0/debian/changelog        
2018-12-31 10:40:44.000000000 +0100
+++ golang-golang-x-sys-0.0~git20181228.9a3f9b0/debian/changelog        
2019-01-03 00:17:22.000000000 +0100
@@ -1,3 +1,10 @@
+golang-golang-x-sys (0.0~git20181228.9a3f9b0-2) unstable; urgency=medium
+
+  * Add 02-do-not-check-for-device-files.patch. Assume that device
+    files are ok and do not check them. Closes: #907191.
+
+ -- Anthony Fok <f...@debian.org>  Wed, 02 Jan 2019 23:44:12 +0000
+
 golang-golang-x-sys (0.0~git20181228.9a3f9b0-1) unstable; urgency=medium
 
   * New upstream version 0.0~git20181228.9a3f9b0
diff -Nru 
golang-golang-x-sys-0.0~git20181228.9a3f9b0/debian/patches/02-do-not-check-for-device-files.patch
 
golang-golang-x-sys-0.0~git20181228.9a3f9b0/debian/patches/02-do-not-check-for-device-files.patch
--- 
golang-golang-x-sys-0.0~git20181228.9a3f9b0/debian/patches/02-do-not-check-for-device-files.patch
   1970-01-01 01:00:00.000000000 +0100
+++ 
golang-golang-x-sys-0.0~git20181228.9a3f9b0/debian/patches/02-do-not-check-for-device-files.patch
   2019-01-03 00:14:52.000000000 +0100
@@ -0,0 +1,13 @@
+From: Santiago Vila <sanv...@debian.org>
+Subject: Do not check for device files and assume they are ok
+
+--- a/unix/dev_linux_test.go
++++ b/unix/dev_linux_test.go
+@@ -14,6 +14,7 @@
+ )
+ 
+ func TestDevices(t *testing.T) {
++      return
+       testCases := []struct {
+               path  string
+               major uint32
diff -Nru golang-golang-x-sys-0.0~git20181228.9a3f9b0/debian/patches/series 
golang-golang-x-sys-0.0~git20181228.9a3f9b0/debian/patches/series
--- golang-golang-x-sys-0.0~git20181228.9a3f9b0/debian/patches/series   
2018-03-02 07:23:30.000000000 +0100
+++ golang-golang-x-sys-0.0~git20181228.9a3f9b0/debian/patches/series   
2019-01-03 00:13:58.000000000 +0100
@@ -1 +1,2 @@
 01-Fix-mips-build-issues.patch
+02-do-not-check-for-device-files.patch

Reply via email to