Hi Andreas! On Sa, 29 Dez 2018, Andreas Henriksson wrote:
> > the issue still persists, so I reopen the bug report and remove the > > patch tag, since this patch doesn't help :-| > > Actually the issue is fixed, but the package is still not building > *reproducibly*. You are right, your patch fixed the ping path issue, but not the ENV_PATH issue, which is still open. I mixed those two into a "reproducible build" issue triggered by usrmerge. > the unreproducible part is the "ENV_PATH" in lg.conf. The ping path is > no longer an issue. Correct. But don't miss the ENV_PATH issue in rancid.conf. > The problem with ENV_PATH is that in one of the builds /bin is included > *twice*, while in the other it's only included *once*. > This is thus not any greater issue than simply a reproducible build > issue, that has no other consequenses. Either version will work on > any system. > > The remaining problem is caused by the logic found in > https://sources.debian.org/src/rancid/3.8-3/configure.ac/#L354 > and there's no way to override that (as far as I can see). > > I can think of the following ways that this could be patched: > a/ wrap the ENV_PATH logic in configure.ac in a if-condition that > only tries to set ENV_PATH if it's not already set, then pass > a static ENV_PATH from debian/rules to configure. > b/ split the resulting ENV_PATH into a list, canonicalize thats > (eg. //bin becomes /bin), then sort and only include unique entries. > ie. fix up > https://sources.debian.org/src/rancid/3.8-3/configure.ac/#L398 > and include the prefix in ENV_PATH instead of at > https://sources.debian.org/src/rancid/3.8-3/etc/lg.conf.sample.in/#L9 > c/ patch lg.conf.sample.in to use a static path provided by you > instead of using the @ENV_PATH@ et.al. (which you'd probably have to > carry downstream forever, which might not be appealing.) I thought about all variants and fear that b/ will increase complexity of ENV_PATH generation, which may fail on upstream updates, so I tend to avoid this. Since @ENV_PATH@ is only used in rancid.conf and lg.conf, while lg.conf has the additional issue, that @prefix@/bin results in //bin, which should be fixed, I decided to go the c/ way and patched these two files with a static path for Debian. If more than these two files were affected, I'd switch over to a/, but in the meantime patching th conf files seems to be the smoothest way. Now I "only" have to find a fix for rancid not building reproducible on salsa CI, which seems to fail on testing ping parameters. Greetings and thanks for your analysis of the issue and my options Roland
signature.asc
Description: PGP signature
