Control: found -1 1:2.11.0-3+deb9u4 Control: found -1 1:2.20.1-1 Control: tag -1 upstream
Hi, (Not the maintainer, just another user who found the failure mode a bit harsh when learning a bit more about git bundles.) Bernhard Übelacker <[email protected]> (2018-08-28): > (gdb) list get_main_ref_store > 1680 > 1681 struct ref_store *get_main_ref_store(struct repository *r) > 1682 { > 1683 if (r->refs) > 1684 return r->refs; > 1685 > 1686 if (!r->gitdir) > 1687 BUG("attempting to get main_ref_store outside of > repository"); > 1688 > 1689 r->refs = ref_store_init(r->gitdir, REF_STORE_ALL_CAPS); > 1690 return r->refs; > 1691 } > > > I think a call to "BUG" is probably too much. > Probably a call to "die" could be more appropriate. > E.g. like "git diff" printing "Not a git repository". > Attached patch does just replace the "BUG" by "die". That seems reasonable to me, I suppose proposing that uptream would help get that merged. With the control commands above, I'm confirming this issue affects git versions currently in stretch and unstable. Cheers, -- Cyril Brulebois ([email protected]) <https://debamax.com/> D-I release manager -- Release team member -- Freelance Consultant
signature.asc
Description: PGP signature
