On Sat, 17 Nov 2018 02:22:59 +0100 Michael Biebl <[email protected]> wrote:
>
> Hi,
>
> pcre2 is the successor of pcre.
> Afaics, libselinux allows linking against pcre2 instead of pcre.
> Please consider switching it over to the newer version of the library.
>
> Build-tested patch is attached.

Would that means that you'll enable regex support in journald :)

That would made pcre2 pseudo-essential, note that the last essential package to use pcre (version 1) is grep. Also, libpcre2 libraries are located in /usr/lib and not /lib, debian is not supporting late mounting /usr for a few releases but that still needs to be noted somewhere.

We also need to keep in mind that the compiled file context files will not be architecture agnostic anymore, but libselinux should be smart enough to ignore these files if their architecture is not matching (ie. in multi-arch case). Unlike on RHEL/Fedora, these files are generated on the machine instead of shipped in a (noarch/arch:all) package so I don't think we need to change anything on how they are handled. (See: https://janzarskyblog.wordpress.com/2017/09/06/why-we-dont-need-to-ship-file_contexts-bin-with-selinux-policy/). So for me that should be fine.

I'll still try to do some benchmarking

Reply via email to