On Sun, Dec 16, 2018 at 02:30:31PM +0100, Vagrant Cascadian wrote:
> On 2018-12-16, Vagrant Cascadian wrote:
> > On 2018-12-16, Wolfgang Schweer wrote:
> >> On Sun, Dec 16, 2018 at 09:30:21AM +0100, Vagrant Cascadian wrote:
> >>> On 2018-12-16, Vagrant Cascadian wrote:
> >>> > I'm now thinking of passing an option --trust-file-mirrors or something
> >>> > like that. Then the trust is explicit, consistent with apt behavior
> >>> > requiring to explicitly trust it. It wouldn't allow different levels of
> >>> > trust for different file mirror types, but it will at least be simpler
> >>> > to code...
> >>> 
> >>> And implemented, please test:
> >>> 
> >>>   
> >>> https://git.launchpad.net/ltsp/commit/?id=85f4e9585d996bde20620a775185d06a6f41dc46
> >>  
> >> The new option is evaluated too late; if set to "True", the sources.list 
> >> file contains 'deb True file:/// ... '.
> 
> Ah, I see the problem. It was not because it was evaluated too late, but
> because you thought it was a boolean. I should make it a proper boolean,
> rather than the way it's currently configured.
> 
> If using a configuration file, you'd want:
> 
>   TRUST_FILE_MIRROR="[trusted=yes]"
> 
> But I think it would be better as a boolean; I'll change it a bit more.

Good job! The current code is now working like expected.  

Thanks for all your work,

Wolfgang

Attachment: signature.asc
Description: PGP signature

Reply via email to