Hi Sunil, On Tue, 11 Dec 2018 14:41:29 -0800 Sunil Mohan Adapa <su...@medhas.org> wrote: > The problem with configuring tt-rss with postgresql turns out to be in > dbconfig-common due to usage of su. Similar bugs were fixed in > quassel-core[1] and monkeysphere[2] packages.
Thanks for the investigation.
> Further, su(1) recommends using
> runuser when used by privileged users.
One learns new things every day.
> Attached patch uses runuser in the pgsql methods instead of su.
Did you run the tests that are part of dbconfig-common with your patch
applied? I am running it now and there seems to be at least one test
case failing.
test_dbc_psql_db_installed_real
case 1: pgsqld in path
case 2: pgsqld not in path
ASSERT:pgsqld should not have been found
I need to check myself what this means.
> The
> shell is not required anymore. However, due to the way single quoted
> strings are passed around in variables such as 'extra', more changes
> would be required. The shell is kept to make the patch minimally impacting.
Thanks for that.
> As the bug impacts all FreedomBox machines trying to install tt-rss,
> please consider making a release with the fix as soon as you can.
If we get a working patch, I'll upload the fix quickly.
Paul
signature.asc
Description: OpenPGP digital signature
