Control: tag -1 + patch

On Thu, 29 Nov 2018, Raphaël Hertzog wrote:
> I have proposed a simple fix which just tries to load the kernel
> module before starting the service, it's simple and reliable. For
> the Debian package, since you have split support for the desktop
> part in a separate package, you might want to add that directive
> through a 
> /lib/systemd/system/open-vm-tools.service.d/desktop.conf
> file extending the basic service file.

I implemented this in the attached patch.

Cheers,
-- 
Raphaël Hertzog ◈ Debian Developer

Support Debian LTS: https://www.freexian.com/services/debian-lts.html
Learn to master Debian: https://debian-handbook.info/get/
>From 1decdd30466d80bf3ef306e586088fdd52382e94 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Rapha=C3=ABl=20Hertzog?= <raph...@offensive-security.com>
Date: Thu, 6 Dec 2018 16:18:17 +0100
Subject: [PATCH] Ensure vmwgfx module is loaded before start of vmtoolsd

This avoids a failure to start the resolutionKMS plugin and it's
achieved through a drop-in snippet extending open-vm-tools.service
adding an ExecStartPre directive loading the module prior to
the start of the service.

Closes: #915031
---
 debian/desktop.conf | 2 ++
 debian/rules        | 3 +++
 2 files changed, 5 insertions(+)
 create mode 100644 debian/desktop.conf

diff --git a/debian/desktop.conf b/debian/desktop.conf
new file mode 100644
index 0000000..6456fd7
--- /dev/null
+++ b/debian/desktop.conf
@@ -0,0 +1,2 @@
+[Service]
+ExecStartPre=-/sbin/modprobe vmwgfx
diff --git a/debian/rules b/debian/rules
index 5214319..f683532 100755
--- a/debian/rules
+++ b/debian/rules
@@ -95,6 +95,9 @@ override_dh_auto_install:
 	mkdir -p debian/open-vm-tools-desktop/etc/xdg/autostart
 	mv debian/open-vm-tools/etc/xdg/autostart/vmware-user.desktop debian/open-vm-tools-desktop/etc/xdg/autostart
 	rm -rf debian/open-vm-tools/etc/xdg
+	
+	mkdir -p debian/open-vm-tools-desktop/lib/systemd/system/open-vm-tools.service.d
+	cp debian/desktop.conf debian/open-vm-tools-desktop/lib/systemd/system/open-vm-tools.service.d/
 
 override_dh_builddeb:
 	dh_builddeb -- -Zxz
-- 
2.20.0.rc2

Reply via email to