severity 915644 wishlist
tags 915644 + patch
quit

HJ wrote:
> On Wed, 5 Dec 2018 at 19:11, Jonathan Nieder <jrnie...@gmail.com> wrote:

>> Hm.  Git already depends on libcurl3-gnutls, which recommends
>> ca-certificates.  Can you say more about your setup where this
>> happened?
>
> I use a minimal debian setup installed with a netinstall and its configured
> not to see suggested or recommended packages as dependencies(since that
> would add a lot of bloat to my system ~500 packages more). However,
> recently I needed git and was unable to clone the https repo. Also since
> this breaks a core funtionality of the package it should be added directly
> to the package so it is visable for everyone by browsing the package
> details with apt or synaptic (Nobody thinks of a dependency of a
> recommended package if he has an issue)

Thanks for the explanation.  Makes sense.

-- >8 --
Subject: debian/control: add Recommends against ca-certificates

Without certificates, cloning an https URL produces

 $ git clone https://gitlab.com/foo.git
 Cloning into 'foo'...
 fatal: unable to access 'https://gitlab.com/foo.git/': server certificate 
verification failed. CAfile: none CRLfile: none

libcurl already Recommends ca-certificates for this purpose, but on a
machine configured not to install Recommends, it may be hard to find
this package in a package manager.  Add a recommendation from the leaf
package for better discoverability.

Fixes: https://bugs.debian.org/915644
Signed-off-by: Jonathan Nieder <jrnie...@gmail.com>
---
 debian/changelog | 7 +++++++
 debian/control   | 2 +-
 2 files changed, 8 insertions(+), 1 deletion(-)

diff --git a/debian/changelog b/debian/changelog
index fc50a86bda..ca8930d63c 100644
--- a/debian/changelog
+++ b/debian/changelog
@@ -1,3 +1,10 @@
+git (1:2.20.0~rc2-1.1) unstable; urgency=low
+
+  * package git: Recommends: ca-certificates for https support (thx HJ;
+    closes: #915644).
+
+ -- Jonathan Nieder <jrnie...@gmail.com>  Wed, 05 Dec 2018 15:36:36 -0800
+
 git (1:2.20.0~rc2-1) unstable; urgency=low
 
   * new upstream release candidate.
diff --git a/debian/control b/debian/control
index 377cf76aa9..b36d764a62 100644
--- a/debian/control
+++ b/debian/control
@@ -30,7 +30,7 @@ Multi-Arch: foreign
 Depends: ${misc:Depends}, ${shlibs:Depends}, perl, liberror-perl,
  git-man (>> ${source:Upstream-Version}), git-man (<< 
${source:Upstream-Version}-.)
 Pre-Depends: ${misc:Pre-Depends}
-Recommends: patch, less, ssh-client
+Recommends: ca-certificates, patch, less, ssh-client
 Suggests: gettext-base, git-daemon-run | git-daemon-sysvinit,
  git-doc, git-el, git-email, git-gui, gitk, gitweb,
  git-cvs, git-mediawiki, git-svn
-- 
2.20.0.rc2.403.gdbc3b29805

Reply via email to