Control: reopen -1
Control: retitle -1 crrcsim: FTBFS on several architectures
Control: severity -1 serious

Hi,

On Fri, 17 Aug 2018 14:36:37 +0000 Agustin Henze <t...@debian.org> wrote:
>    [ Agustin Henze ]
>    * Add patch for removing an extra std::cerr at the end of an output stream
>    * Update sys_io_missing patch, add support for hppa architecture (Closes:
>      #839161). Thanks to "Helge Deller" <del...@gmx.de>

The patch in the package is broken:

-#  elif defined(__powerpc__)
+#  elif defined(__powerpc__) || defined(__mips__) || defined(__mipsel__) ||\
+    defined(__s390__) || defined(__s390x__) || defined(__sparc__) || 
defined(__sh__) ||\
+    defined(__hppa_)

You made it __hppa_, while it should be __hppa__ (two underscores at the end).

BTW this also fails on arm64 (release architecture, hence RC severity), and on
m68k and riscv64. Can you add those to the list? Maybe there's a better way
to do this?

The code has:

#    ifdef HAVE_SYS_IO_H
#     include <sys/io.h>

Yet that fails. That's because AC_CHECK_HEADERS will define the value to 0 or 
1, so it passes the ifdef.
That should be changed to

#    if HAVE_SYS_IO_H

Cheers,
Emilio

Reply via email to