Package: enca
Version: 1.19-1
Severity: normal
Tags: patch
User: [email protected]
Usertags: usrmerge

Dear Maintainer,

The reproducible build spotted a difference in your package when
built on a usrmerged system vs a non-merged system:
https://tests.reproducible-builds.org/debian/rb-pkg/unstable/amd64/enca.html

It seems a few files contains the full path of 'mktemp' found via
AC_PROG_PATH during build.

Since PATH defaults to contain /usr/bin before /bin the found path will
be /usr/bin/mktemp on a usrmerged system, since both paths are
essentially the same thing there. This is however not desirable on
a non-merged system where it needs to be /bin/mktemp.

The attached patch fixes the problem by explicitly specifying
the default path via MKTEMP_PROG environment variable as documented
in AC_PROG_PATH documentation.

(This is likely a good idea either way, since otherwise hypothetical
problems could happen for users building on their system with
/usr/local/bin/... or ~/bin/....)

Regards,
Andreas Henriksson
diff -Nru enca-1.19/debian/changelog enca-1.19/debian/changelog
--- enca-1.19/debian/changelog  2016-09-05 16:23:32.000000000 +0200
+++ enca-1.19/debian/changelog  2018-11-28 21:59:20.000000000 +0100
@@ -1,3 +1,11 @@
+enca (1.19-1.1) UNRELEASED; urgency=medium
+
+  * Non-maintainer upload.
+  * Pass MKTEMP_PROG=/bin/mktemp to configure instead of finding in PATH
+    - this fixes reproducible build issue on merged-usr vs non-merged.
+
+ -- Andreas Henriksson <[email protected]>  Wed, 28 Nov 2018 21:59:20 +0100
+
 enca (1.19-1) unstable; urgency=medium
 
   * New upstream release.
diff -Nru enca-1.19/debian/rules enca-1.19/debian/rules
--- enca-1.19/debian/rules      2016-01-07 09:27:18.000000000 +0100
+++ enca-1.19/debian/rules      2018-11-28 21:59:15.000000000 +0100
@@ -5,7 +5,8 @@
               --libexecdir=\$${prefix}/lib \
               --with-librecode \
               --with-libiconv \
-              --disable-rpath
+              --disable-rpath \
+              MKTEMP_PROG=/bin/mktemp
 
 override_dh_strip:
        dh_strip --dbg-package=libenca-dbg

Reply via email to