Hi, Quoting Guillem Jover (2018-11-22 13:12:05) > > in your original commit you were talking about "some tools". > > > > This suggests that you know tools that behave wrongly. > > > > If you share the tools you know of, then we could file bugs. > > I think that would be difficult, I'm afraid the bulk of these > tools are human brains! :D > > See for example #911341 which is something I recently stumbled upon. > The tools here work as intended, but the human made a very > comprehensible mistake. > > I mean, yes, we could improve lintian, perhaps even some of > dpkg-gensymbols, and similar to warn or maybe not propose this kind > of situation, but in the end, any time you strip the revision in any > dependency field or similar, you can end up with broken comparisons > given the current algorithm.
I then suggest two things: Instead of checking whether the upstream version contains dashes, check whether the .symbols file contains a version format that avoids bugs like #911341. Improve the tag description to be more explicit about which problem is being solved, for example by making the tag specific for the symbols file error. Additionally: I don't know how the machinery works that compares versions in symbols files, but maybe it could be improved to make sure that this kind of problem doesn't happen anymore? Thanks! cheers, josch
signature.asc
Description: signature
