severity 356765 wishlist
thanks
On 13 Mar 2006, Will Dyson told this:
> The step of 'make-kpkg clean' where it performs
>
> rm -f core `find . \( -name '*.orig' -o -name '*.rej' -o -name '*~'
> -o -name '*.bak' -o -name '#*#' -o -name '.*.orig' -o
> -name '.*.rej' -o -name '.SUMS' -o -size 0 \) -print` TAGS
>
> takes a very long time when the kernel build directory is a kernel
> git repository. The problem appears to be the last clause of the
> find, where it searches for size=0 files. This causes it to stat()
> every file in the directory, including all the git files.
Hmm. I guess running from a git repo directory was not within
the parameters where make-kpkg is designed to work in.
> How long is very long? I'm not sure, as I've never had the patience
> to let it run to completion. At least 5 minutes (i'm sure it would
> run longer, but that is the longest I've every actually timed).
>
> The filesystem on this volume is reiserfs with tail packing enabled.
>
> Perhaps the .git directory could be special-cased out of the find?
> Or is the -size 0 clause actually needed at all?
The removal of zero size files is useful sometimes when
patches have been applied. I'll have to see what impact removing it
would have in different scenarios, if any, before removing that
clause.
While I feel there is unlikely to be any negative impact, I
still need to go and test this.
manoj
--
"You are WRONG, you ol' brass-breasted fascist poop!" Bloom County
Manoj Srivastava <[EMAIL PROTECTED]> <http://www.debian.org/%7Esrivasta/>
1024D/BF24424C print 4966 F272 D093 B493 410B 924B 21BA DABB BF24 424C
--
To UNSUBSCRIBE, email to [EMAIL PROTECTED]
with a subject of "unsubscribe". Trouble? Contact [EMAIL PROTECTED]
