Package: munin-plugins-extra
Version: 2.0.42-5~bpo9+1
Severity: normal

Dear Maintainer,

There was an issue¹ reported to munin github which proposed a "fix" for
one person's hardware, that broke on everyone elses hardware.

Looking at two servers (both SuperMicro), showing ipmitool output and
munin-run output with the version of ipmi_sensor_ in the 2.0.33-1
package:

  server1# ipmitool -I open sensor get "FAN 1"
  Locating sensor record...
  Sensor ID              : FAN 1 (0x41)
   Entity ID             : 29.1
   Sensor Type (Threshold)  : Fan
   Sensor Reading        : 4800 (+/- 0) RPM
   Status                : ok
   Lower Non-Recoverable : 300.000
   Lower Critical        : 450.000
   Lower Non-Critical    : 600.000
   Upper Non-Critical    : 18975.000
   Upper Critical        : 19050.000
   Upper Non-Recoverable : 19125.000
   Positive Hysteresis   : 75.000
   Negative Hysteresis   : 75.000
   Assertion Events      :
   Assertions Enabled    : lcr- lnr- unc+ ucr+ unr+
   Deassertions Enabled  : lcr- lnr- unc+ ucr+ unr+

  server1# munin-run ipmi_sensor_u_rpm config | grep fan_1
  fan_1.label FAN 1
  fan_1.warning :18975.000
  fan_1.critical 450.000:19050.000

  server2# ipmitool -I open sensor get "FAN1"
  Locating sensor record...
  Sensor ID              : FAN1 (0x41)
   Entity ID             : 29.1
   Sensor Type (Threshold)  : Fan
   Sensor Reading        : 800 (+/- 0) RPM
   Status                : ok
   Lower Non-Recoverable : 300.000
   Lower Critical        : 500.000
   Lower Non-Critical    : 700.000
   Upper Non-Critical    : 25300.000
   Upper Critical        : 25400.000
   Upper Non-Recoverable : 25500.000
   Positive Hysteresis   : 100.000
   Negative Hysteresis   : 100.000
   Assertion Events      :
   Assertions Enabled    : lcr- lnr- ucr+ unr+
   Deassertions Enabled  : lcr- lnr- ucr+ unr+

  server2# munin-run ipmi_sensor_u_rpm config | grep fan1
  fan1.label FAN1
  fan1.critical 500.000:25400.000

Compared to munin-run output with the version of ipmi_sensor_ in the
2.0.42-5~bpo9+1 package:

  server1# munin-run ipmi_sensor_u_rpm config | grep fan_1
  fan_1.label FAN 1
  fan_1.warning 18975.000:
                ^^^^^^^^^^
  fan_1.critical 19050.000:450.000
                 ^^^^^^^^^^^^^^^^^

  server2# munin-run ipmi_sensor_u_rpm config | grep fan1
  fan1.label FAN1
  fan1.critical 25400.000:500.000
                ^^^^^^^^^^^^^^^^^

The Lower/Upper, Critical/Non-Critical values have been reversed.

The following lines of code in the plugin are causing this reversal:

  268: # TODO add 'fans'
  269: if 'rpm' == unit:
  270:     warn = "%s:%s" % (warn_u, warn_l)
  271:     crit = "%s:%s" % (crit_u, crit_l)
  272: else:
  273:     warn = "%s:%s" % (warn_l, warn_u)
  274:     crit = "%s:%s" % (crit_l, crit_u)

Apologies for not commenting on the upstream github repository directly,
as I do not have a github account.  However another user had reported
the same problem in the last comment² of the closed bug report.

¹ https://github.com/munin-monitoring/munin/issues/301
² https://github.com/munin-monitoring/munin/issues/301#issuecomment-380997171

-- System Information:
Debian Release: 9.6
  APT prefers stable
  APT policy: (601, 'stable'), (500, 'stable-updates'), (500, 'stable-debug')
Architecture: amd64 (x86_64)
Foreign Architectures: i386

Kernel: Linux 4.18.0-0.bpo.1-amd64 (SMP w/8 CPU cores)
Locale: LANG=en_US.UTF-8, LC_CTYPE=en_US.UTF-8 (charmap=UTF-8), 
LANGUAGE=en_US.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash
Init: systemd (via /run/systemd/system)

Versions of packages munin-plugins-extra depends on:
ii  munin-common  2.0.42-5~bpo9+1
ii  perl          5.24.1-3+deb9u4

munin-plugins-extra recommends no packages.

Versions of packages munin-plugins-extra suggests:
pn  libcache-memcached-perl  <none>
ii  libnet-ip-perl           1.26-1
ii  libnet-netmask-perl      1.9022-1
ii  libnet-snmp-perl         6.0.1-2
ii  libnet-telnet-perl       3.04-1
ii  libtext-csv-xs-perl      1.26-1
ii  libxml-libxml-perl       2.0128+dfsg-1+deb9u1
ii  python3                  3.5.3-1

-- Configuration Files:
/etc/munin/plugin-conf.d/dhcpd3 [Errno 13] Permission denied: 
'/etc/munin/plugin-conf.d/dhcpd3'
/etc/munin/plugin-conf.d/spamstats [Errno 13] Permission denied: 
'/etc/munin/plugin-conf.d/spamstats'

-- no debconf information

-- 
Gerald Turner <gtur...@unzane.com>        Encrypted mail preferred!
OpenPGP: 4096R / CA89 B27A 30FA 66C5 1B80  3858 EC94 2276 FDB8 716D

Attachment: signature.asc
Description: PGP signature

Reply via email to