On Sat, Nov 17, 2018 at 12:02:38PM -0200, Gabriel F. T. Gomes wrote: > On 17 Nov 2018, Adam Borowski wrote: > > >Thus, please add support for .tar.zst (note: no 'd'). > > I can certainly add support for `.tar.zst' alone, but shouldn't it also > work for other extensions, as well? (it works for other compression > algorithms). For instance: > > $ ls > bla.crazy bla.gem.gz bla.tar.bz2 bla.tgz > bla.crazy.gz bla.spkg.gz bla.tar.gz > $ tar f bla.[TAB] > bla.gem.gz bla.spkg.gz bla.tar.bz2 bla.tar.gz bla.tgz > $ tar f bla.[CURSOR] > > I think it should also complete for `.gem.zst', `.spkg.zst'
I don't know what those .gem or .spkg thingies are, but you sound right here. > and even for `.tar.zstd', `.gem.zstd', `.spkg.zstd', as people are > probably going to create archives with such extensions. Bad idea -- tar doesn't consider .zst_d_ as a valid extension, and produces an uncompressed tarball (like it does with any unknown extension). Thus, bash-completion definitely shouldn't show them up. Yeah, it's confusing to have .zst for a compressor named "zstd" -- but then, there's .gz for gzip, and .lzo for lzop. And this extension has been reportedly used by zstd's upstream for years, thus it's too late to change -- too many programs already accepted patches without the d. On the other hand, there's also .tzst (shorthand for .tar.zst) which only some tools recognize; it might be good to allow it. Meow! -- ⢀⣴⠾⠻⢶⣦⠀ ⣾⠁⢠⠒⠀⣿⡁ A dumb species has no way to open a tuna can. ⢿⡄⠘⠷⠚⠋⠀ A smart species invents a can opener. ⠈⠳⣄⠀⠀⠀⠀ A master species delegates.