control: -1 affects git-buildpackage Hi, On Wed, Oct 31, 2018 at 09:06:39AM -0300, David Bremner wrote: > Package: git-debrebase > Version: 8.0 > Severity: normal > > > I'm not sure if this is a case of bad input, but convert-from-gbp ends > up with some junk in the commit message when converting a base64 > encoded patch. > > to reproduce: > > debcheckout nullmailer > cd nullmailer && git reset --hard debian/1%2.1-7 > git debrebase --force convert-from-gdb upstream/2.1 > git log -1 master~3
This is caused by git-mailinfo not properly stopping at the end of the UTF-8 output that is a patch file looking like; -------------------------- [rfc822-headers] [base64 encoded text] --- [actual patch data] -------------------------- gets garbage at the end. To reproduce: curl 'https://salsa.debian.org/bremner/nullmailer/raw/7744ac65db116ee2cf5296060eb1b0681e743703/debian/patches/0004-Sort-files-in-archive-reproducible-builds.patch?inline=false'> base64.patch git mailinfo -k out /dev/null 2>/dev/null < base64.patch cat out shows garbled data at the end of the patch. Cheers, -- Guido
