Package: ocsinventory-agent
Version: 2:2.4.2-1
Severity: important
Tags: patch
User: ubuntu-de...@lists.ubuntu.com
Usertags: origin-ubuntu disco ubuntu-patch
Hi Xavier,
With the upload of perl 5.28, the ocsinventory-agent autopkgtests are now
failing:
[...]
autopkgtest [11:17:40]: test command2: /usr/share/pkg-perl-autopkgtest/runner
runtime-deps
autopkgtest [11:17:40]: test command2: [-----------------------
# Failed test ' /usr/bin/perl -w -M"Ocsinventory::Agent" -e 1 2>&1 produced
no (non-whitelisted) output'
# at /usr/share/pkg-perl-autopkgtest/runtime-deps.d/use.t line 108.
# Failed test 'env PERL_DL_NONLAZY=1 /usr/bin/perl -w
-M"Ocsinventory::Agent" -e 1 2>&1 produced no (non-whitelisted) output'
# at /usr/share/pkg-perl-autopkgtest/runtime-deps.d/use.t line 108.
# Looks like you failed 2 tests of 4.
[...]
(https://ci.debian.net/packages/o/ocsinventory-agent/unstable/amd64/)
Applying the attached patch to remove the useless lines of code fixes the
autopkgtest failure in Ubuntu, and should do so for Debian as well.
--
Steve Langasek Give me a lever long enough and a Free OS
Debian Developer to set it on, and I can move the world.
Ubuntu Developer https://www.debian.org/
slanga...@ubuntu.com vor...@debian.org
diff -Nru ocsinventory-agent-2.4.2/debian/patches/no-useless-concat.patch
ocsinventory-agent-2.4.2/debian/patches/no-useless-concat.patch
--- ocsinventory-agent-2.4.2/debian/patches/no-useless-concat.patch
1969-12-31 16:00:00.000000000 -0800
+++ ocsinventory-agent-2.4.2/debian/patches/no-useless-concat.patch
2018-11-06 16:59:26.000000000 -0800
@@ -0,0 +1,19 @@
+Description: drop pointless statements that generate a perl warning
+ Perl 5.28 warns of:
+ # Useless use of concatenation (.) or string in void context at
/usr/share/perl5/Ocsinventory/Agent/Network.pm line 53.
+ This generates autopkgtests failures, so just remove the useless lines.
+Author: Steve Langasek <steve.langa...@ubuntu.com>
+
+Index: ocsinventory-agent-2.4.2/lib/Ocsinventory/Agent/Network.pm
+===================================================================
+--- ocsinventory-agent-2.4.2.orig/lib/Ocsinventory/Agent/Network.pm
++++ ocsinventory-agent-2.4.2/lib/Ocsinventory/Agent/Network.pm
+@@ -49,8 +49,6 @@
+ my $version = 'OCS-NG_unified_unix_agent_v';
+ $version .= exists
($self->{config}->{VERSION})?$self->{config}->{VERSION}:'';
+ $self->{ua}->agent($version);
+- $self->{config}->{user}.",".
+- $self->{config}->{password}."";
+ $self->{ua}->credentials(
+ $uaserver, # server:port, port is needed
+ $self->{config}->{realm},
diff -Nru ocsinventory-agent-2.4.2/debian/patches/series
ocsinventory-agent-2.4.2/debian/patches/series
--- ocsinventory-agent-2.4.2/debian/patches/series 2018-08-01
02:49:49.000000000 -0700
+++ ocsinventory-agent-2.4.2/debian/patches/series 2018-11-06
16:57:18.000000000 -0800
@@ -1,2 +1,3 @@
no_postinst_questions.patch
propagate-ccflags.patch
+no-useless-concat.patch
