On Mon, Nov 05, 2018 at 05:31:27PM +0000, Dimitri John Ledkov wrote: > > I've noticed that your for loops in your rules files are buggy. > > This things: > > > > for pyver in $(pyversions); do \ > > echo "Building Boost.Python for python version $$pyver"; \ > > $(JAM) --build-dir=build-$$pyver --stagedir=stage-$$pyver > > --user-config=$(CURDIR)/user-config-$$pyver.jam --with-python --with-mpi > > python=$$pyver; \ > > done > > > > is buggy, as it wouldn't cause a build failure in the instance $(JAM) > > failed. > > This is intentional, such that when new pythons are added as supported > the build doesn't fail, as it is typical that adjustments are needed. > > I do not believe this is in fact serious. As the build does error out > eventually, if none of the pythons managed to build.
Have you actually read Policy 4.6? Every time you put more than one shell command (this includes using a loop) in a makefile command you *must* make sure that errors are trapped. This is a *must* requirement in Debian Policy, definitely not wishlist. Thanks.
