Package: arcanist
Version: 0~git20180509-2
Severity: important
Tags: patch
Dear Maintainer,
on Debian unstable, arc diff fails in the linting phase with the
following error message:
Error while loading file
"/usr/share/arcanist/src/lint/linter/xhpast/rules/ArcanistPHPCompatibilityXHPASTLinterRule.php":
"continue" targeting switch is equivalent to "break". Did you mean to use
"continue 2"?
(Run with `--trace` for a full exception trace.)
The error is related to a "continue" within a switch-case statement,
and it is fixed by the patch inlined. I have not done a great deal
of investigation, merely replaced the "continue" by "continue 2" as
suggested in the error message. This makes arc diff run through
without error. It might intrduce more subtle bugs, though...
Best regards,
Pascal
-- Patch:
--- ArcanistPHPCompatibilityXHPASTLinterRule.php.orig 2018-10-22
11:19:45.203969434 +0200
+++ ArcanistPHPCompatibilityXHPASTLinterRule.php 2018-10-22
11:01:11.919001985 +0200
@@ -70,7 +70,7 @@
$symbol = $params->getChildByIndex(0);
if (!$symbol->isStaticScalar()) {
- continue;
+ continue 2;
}
$symbol_name = $symbol->evalStatic();
-- System Information:
Debian Release: buster/sid
APT prefers unstable-debug
APT policy: (500, 'unstable-debug'), (500, 'unstable'), (500, 'stable')
Architecture: amd64 (x86_64)
Kernel: Linux 4.18.0-2-amd64 (SMP w/4 CPU cores)
Locale: LANG=en_GB.UTF-8, LC_CTYPE=en_GB.UTF-8 (charmap=UTF-8),
LANGUAGE=en_GB:en (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash
Init: systemd (via /run/systemd/system)
LSM: AppArmor: enabled
Versions of packages arcanist depends on:
ii libphutil 0~git20180509-2
ii php-cli 1:7.3+66
ii php-curl 1:7.3+66
ii php-xml 1:7.3+66
ii php7.2-cli [php-cli] 7.2.11-2
ii php7.2-curl [php-curl] 7.2.11-2
ii php7.2-xml [php-xml] 7.2.11-2
ii php7.3-cli [php-cli] 7.3.0~rc3-2
ii php7.3-curl [php-curl] 7.3.0~rc3-2
ii php7.3-xml [php-xml] 7.3.0~rc3-2
arcanist recommends no packages.
Versions of packages arcanist suggests:
ii python 2.7.15-3
-- no debconf information
