Am 21.10.18 um 23:51 schrieb Yavor Doganov: > Markus Koschany wrote: >> I only noticed that the Close button in the "Info" submenu doesn't >> work as intended. > > There is no "Info" submenu; I guess you mean the Close button in the > About dialog? None of the patches touches this code and I can > reproduce with 1.8.1-7+b1 so it's not a regression.
Yes, Info is the German translation for About in this case. Ok then nevermind. >> Please consider to submit a debdiff for future patches because it is >> easier to apply. > > Apologies; I thought it is self-explanatory because I mentioned that > no-esound.patch replaces add-esound-as-dependency.patch and the other > patches are naturally appended to the series in the order they're > attached: > > glib-single-include.patch > no-esound.patch > crash_after_intro.patch > desktop_lintian.patch > add_hungarian_translation.patch > no-libgnome.patch > gsettings-port.patch > > I'll be more careful in the future but it's difficult to please all > maintainters as people have different workflows (some dislike debdiffs > with upstream patches because they're somewhat difficult to read, some > hate spamming bugs belonging to the same package with semi-identical > debdiffs, some will reject incremental debdiffs as they think they're > unnecessary burden, you name it). Yeah, but everyone except me is wrong. :) I overlooked that the no-esound.patch replaces add-esound-as-dependency.patch. That explains why I had to manually rebase the patch. Well, not a big deal. Usually debdiffs are the way to go because you have to apply only one diff instead of multiple ones. Whatever. Regards, Markus
signature.asc
Description: OpenPGP digital signature
