On Thu, 18 Oct 2018 15:37:15 +0200 Wojciech Muła <wojciech_m...@poczta.onet.pl> wrote:
>Hi Andreas, > >Thank you for the answer. This functionality is crucial for me, so I >spent some time looking at this. The result is the attached patch >(against sources obtained by 'apt-get source geeqie'). It works on my >machine. > >There were two problems: > >1. Copying 'absolute' string onto memory of 'link_target'; > 'absolute' is most times longer than the length of 'link_target', > which is the cause of memory corruption and crashes. > >2. Possible problem: using 'absolute' as a target for realpath. >Function > realpath expects buffer of size PATH_MAX, and -- due to weird logic > in ifdefs I removed -- it might be too short. I think it's safer to > let realpath allocate sufficient memory and then just copy it. > >best regards >Wojciech > Excellent! I have tested it, and it seems to work fine - I have suggested it upstream in https://github.com/BestImageViewer/geeqie/issues/544 and I will of course see that you are listed as author. (You don't mind having name and email provided to upstream?) Many thanks! /Andreas gus...@debian.org andr...@ronnquist.net
