On 2018-10-01 07:49:59 -0700, Noah Meyerhans wrote: > On Mon, Oct 01, 2018 at 10:08:59AM +0200, Vincent Lefevre wrote: > > > * Preserve locally set ENABLED=1 setting from /etc/default/spamassassin > > > when installing on systemd-based systems. (Closes: 884163, 858457) > > > > Since ENABLED has normally been ignored on systemd-based systems, > > it is set to 0 on most of them (and spamd was enabled by default), > > thus this isn't a fix. > > Please elaborate on your claim, because I don't see it. If a user has > set ENABLED=1 and upgrades to this package, spamd will be enabled. If > ENABLED=0, or is unset, then they will get the default behavior, which > is that spamd is disabled. This is the desired behavior, thus the bug is > closed.
As documented in /etc/default/spamassassin, ENABLED should have no effect with systemd. AFAIK, when I installed my machine a year ago, spamd was running (ENABLED=0, but it isn't taken into account). This was no longer the case after the upgrade to 3.4.1-6+deb9u1. > It's likely that most people who were going to be impacted by this bug > have long since fixed it themselves by enabling the systemd service. Yes, perhaps (not sure since there hasn't been any announce that spamd was no longer run by default). > However, it's possible that there are a few systems out there still > running sysvinit that will transition to systemd, and for them this fix > is relevant. OK, so you mean that the bug fix was just for this case, and for the others, users had to correct the issue manually. BTW, I'm wondering why /usr/share/doc/spamassassin/README.Debian.gz says "spamd, the daemonized form of spamassassin, is generally the preferred way of running spamassassin." but it is not run by default. This seems illogical, in particular as the general recommendation for packages is to run daemons by default. -- Vincent Lefèvre <vinc...@vinc17.net> - Web: <https://www.vinc17.net/> 100% accessible validated (X)HTML - Blog: <https://www.vinc17.net/blog/> Work: CR INRIA - computer arithmetic / AriC project (LIP, ENS-Lyon)
