Hi! On Mon, Aug 27, 2018 at 11:02:42PM +0200, Pierre-Elliott Bécue wrote: > Here is a rough skeleton of patch.
Thank you for it! > I'd just like to hear if the idea seems fine with you. It's supposed to rely > on django.contrib.messages that seems implemented in > deblayout/templates/debian-base.html. Right. do you also have some way to show how it displays? I tried myself injecting a "message" in a random place and it looked not styled at all, which is a pity. I'd say it should at least in a similar way as e.g. https://nm.debian.org/process/503/keycheck the yellow/orange box. it seems to be because using having messages.ERROR adds "error" to the tags and so it doesn't "fallback" to the "important" tags that is used as a css class. Do you think we should just add an error class to the CSS? or maybe just adding "important" to the tags in the add_message() call. Anyway, I like the proposal, please propose further :) -- regards, Mattia Rizzolo GPG Key: 66AE 2B4A FCCF 3F52 DA18 4D18 4B04 3FCD B944 4540 .''`. more about me: https://mapreri.org : :' : Launchpad user: https://launchpad.net/~mapreri `. `'` Debian QA page: https://qa.debian.org/developer.php?login=mattia `-
signature.asc
Description: PGP signature
