On Thu, Sep 27, 2018 at 2:21 AM Chris Lamb <la...@debian.org> wrote: > Hi Tom, > > > Otherwise it should be fine aside from a few gripes from the pedantic > > lintian checks. > > Hm, why don't you just fix these?
Time, mostly. Was expecting not to be available for a while, but had some spare time today to wrap it up. One outstanding lint check I'm not sure if I should be actioning yet: P: hiredis source: debug-symbol-migration-possibly-complete > --dbgsym-migration='libhiredis-dbg (line 37) > I should leave that one be until after this upload, right? > Also, before I upload please could > you address: > > * Use compat level 11. > > * Add <!nocheck> to the relevant build-dependencies. > > * Drop unnecessary cruft (DEB_DESTDIR, "#export DH_VERBOSE=1" etc. > etc.) > > Should be all done. Of note: - Haven't used the build profile stuff before, hopefully I'm doing it right. - I think dh_fixperms (or something else independent of the build) may be marking .pc/.cmake files under usr/lib, so had to work around that in override_dh_fixperms. Not sure if there's a better way. - No GPG signatures available upstream, so added a lintian override for that for now. Cheers, Tom -- *Tom Lee */ http://tomlee.co / @tglee <http://twitter.com/tglee>
