On 2018-09-21 13:44, Guido Günther wrote: >> In 'features' I've implemented two things: >> * %(version)s substitution for tarball-dir >> * preexport hooks that run before the tarballs get selected from the >> tarball-dir (the hook can so some magic to bring the tarballs into >> existence) >> These are at least proof-of-concept implementations, they may lack >> proper documentation etc.
> The preexport and version substitution stuff looks good as well and I'm > happy to pull it in if it gets tests and doc updates (as you suggested). I can write documentation if you point me to the correct files ... but I'm not sure how to write proper tests for these things. > Only thing I'm unsure is if we really want version_to_tag here or just > replace the upstream version verbatim. With version_to_tag the > directories would need to be named like the debian tag instead of the > upsteam version. Was that your intend or was it just simpler to do? > Cheers, Yes, this was just a hack - it was just the easiest interface I could find to do the substitution ... and while I only mentioned %(version)s, it should probably support the other variants as well, to not cause confusion. Maybe repo should have a generic method to substitute the %(version)s family of placeholders in an arbitrary string, that could be used for both cases? repo.a_better_name_for_substitute_version_placeholder(string, version) Andreas
