On 9/2/18 16:42, Guus Sliepen wrote:
> On Sun, Sep 02, 2018 at 03:34:46PM +0200, Michael Biebl wrote:
> 
>> On Mon, 28 May 2018 11:08:00 +0200 Eric Valette <eric.vale...@free.fr>
>> wrote:
>>
>>> When upgrading, you're stuck with the last message in console "setting up
>>> ifupdown" and nothing else. The machine dropped its ip address but
>>> seems to fails to acquire a new one. and stay like this for minutes.
>>
>> I'm suprised ifupdown reconfigures interfaces during package upgrades.
>> Guus, is that intentional?
> 
> That's not intentional. It seems I forgot to add --no-start to the calls
> to dh_installsystemd.

Well, networking.service has a corresponding init script of the same
name, so dh_installinit should already cover that (a bit strange, but
atm dh_installinit and dh_installsystemd are entangled that way for
services which have a matching init script. This will change in the
future though, where dh_installinit and dh_installsystemd will be
disentangled). So yeah, it's probably a good idea to be pro-active and
add --no-start to dh_installsystemd (even if it does nothing atm).

That said, I notice that you have the dh_installsystemd calls in
override_dh_installinit. You should consider moving those to
override_dh_installsystemd, otherwise you'll get unexpected results
(just have a look at the generated maintscript code where e.g.
ifupdown-pre.service is handled twice).
Looking at
https://buildd.debian.org/status/fetch.php?pkg=ifupdown&arch=i386&ver=0.8.34&stamp=1527284212&raw=0
you'll see:

   debian/rules override_dh_installinit
make[1]: Entering directory '/<<PKGBUILDDIR>>'
dh_installinit --name=networking --no-start
dh_installinit --name=ifupdown-wait-online --no-start --no-scripts
install -p -m 0644 debian/networking.defaults
debian/ifupdown/etc/default/networking
dh_installinit --name=networking --noscripts
dh_installsystemd --name=networking
dh_installsystemd --name=ifup@
dh_installsystemd --name=ifupdown-pre
dh_installsystemd --no-enable --no-start --name=ifupdown-wait-online
make[1]: Leaving directory '/<<PKGBUILDDIR>>'
   dh_installsystemd -a

"dh_installsystemd -a" will generate maintscript code for ifupdown-pre
and ifupdown-wait-online (again)

-- 
Why is it that all of the instruments seeking intelligent life in the
universe are pointed away from Earth?

Attachment: signature.asc
Description: OpenPGP digital signature

Reply via email to