Hi Adam, On Mon, 13 Aug 2018 22:12:17 +0100 "Adam D. Barratt" <[email protected]> wrote: > On Mon, 2018-08-13 at 15:21 +0200, Agustin Henze wrote: > > Please review if this patch is ok for apply, > > It looks like you already committed it? >
Oh, yes. Sorry about the cross communication. After sending the patch I saw
that devscripts is already migrated to salsa. So, I'd prefer to keep the
discussion there.
[...]
> > --- /usr/bin/uscan 2018-08-13 15:12:31.374367891 +0200
> > +++ uscan 2018-08-13 15:12:27.758379028 +0200
> > @@ -3294,7 +3294,7 @@
> > uscan_verbose "Matching pattern:\n @patterns\n";
> > }
> > my @hrefs;
> > - while ($content =~
> > m/<\s*a\s+[^>]*href\s*=\s*([\"\'])(.*?)\1/sgi) {
> > + while ($content =~
> > m/<\s*a[^>]*\s+href\s*=\s*([\"\'])(.*?)\1/sgi) {
>
> I'd re-insert the original spaces. Otherwise you're currently accepting
> "<aubergine href=" and the like, which while unlikely is still
> incorrect.
Yes, you're right... What I did now is to remove the regex and use the
HTML::LinkExtor which does the job very well and we don't have to maintain the
nightmare regex anymore.
Cheers,
--
TiN
signature.asc
Description: OpenPGP digital signature
