Hi Niko,

On 19-07-18 13:41, Niko Tyni wrote:
> The relevant code in lib/testdesc.py:_parse_debian_depends() :
> 
>             for dep in alt_group_str.split('|'):
>                 (pkg, version) = _debian_check_dep(testname, dep)
>                 if pkg in my_packages_no_arch:
>                     adtlog.debug('marked %s as a synthesised dependency' % 
> pkg)
>                     _synthesize_deps(synthdeps, dep, testbed_arch)
>             deps.append(alt_group_str)
> 
> I think breaking out of the for loop after the first time
> we call _synthesize_deps() would work?

From a quick look that sounds like it works in most cases, yes. However,
you don't actually know what the apt run before actually installed, so
if you want to do the right thing you need to check which one got installed.

I don't know yet which runners run this code and also which use cases we
could screw up this way. E.g. would we actually fix Samuel's case
(Nullrunner)?

Paul

Attachment: signature.asc
Description: OpenPGP digital signature

Reply via email to