Sean Whitton writes ("Bug#869146: dgit: should never add .orig to the .changes 
more than once"):
> On Tue, Jun 26 2018, Ian Jackson wrote:
> > Of course if you had followed dgit's advice you would not have
> > experienced this but :-)
> 
> I must have been sure that dgit was wrong to tell me to do that in this
> case.  Next time it comes up for me, I'll file a bug saying exactly why
> I think the advice was wrong.  Thanks for the fix!

In this particular situation, what happened was that "git push"
failed.  dgit cannot easily know whether that was because the remote
rejected the push (in which case reusing the version number for new
tags etc. is fine), or because of a network communication error (in
which case the remote may well have stored some of the data).

You can read the error message and know it's the former, so you were
right, except of course for the fact that you managed to find a
dgit bug :-).  The bug would show up in other situations too.

It might be possible to do better with this by, oh, I don't know,
parsing the error messages, or something.  Or by filing a bug against
git to request the ability for a remote receive hook to communicate
this kind of thing to the client.  I decided that version numbers are
cheap enough that this isn't worth the effort.

HTH :-).

Ian.

-- 
Ian Jackson <ijack...@chiark.greenend.org.uk>   These opinions are my own.

If I emailed you from an address @fyvzl.net or @evade.org.uk, that is
a private address which bypasses my fierce spamfilter.

Reply via email to