Bug#902443: Please add DAEMON_OPS to the service file

[Alf Gaida]

Package: quasselcore
Severity: normal
Tags: patch

Dear maintainer,

please add DAEMON_OPTS to the service file similar to the init:

start_server() {
     start-stop-daemon --start --quiet --pidfile $PIDFILE --make-pidfile \
     --background --chuid $DAEMONUSER --exec $DAEMON \
     -- --logfile=$LOGFILE --loglevel=$LOGLEVEL --configdir=$DATADIR \
     --port=$PORT \
     $DAEMON_OPTS }

ExecStart=/usr/bin/quasselcore --configdir=${DATADIR} --logfile=${LOGFILE} 
--loglevel=${LOGLEVEL} --port=${PORT}

should be

ExecStart=/usr/bin/quasselcore --configdir=${DATADIR} --logfile=${LOGFILE} 
--loglevel=${LOGLEVEL} --port=${PORT} ${DAEMON_OPTS}


Cheers Alf

-- System Information:
Debian Release: buster/sid
  APT prefers unstable-debug
  APT policy: (500, 'unstable-debug'), (500, 'testing-debug'), (500, 
'buildd-unstable'), (500, 'unstable'), (500, 'testing'), (500, 'stable'), (1, 
'experimental')
Architecture: amd64 (x86_64)
Foreign Architectures: i386

Kernel: Linux 4.17.2-towo.2-siduction-amd64 (SMP w/8 CPU cores)
Locale: LANG=de_DE.utf8, LC_CTYPE=de_DE.utf8 (charmap=UTF-8), LANGUAGE= 
(charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash
Init: systemd (via /run/systemd/system)
LSM: AppArmor: enabled

diff --git a/debian/quassel-core.quasselcore.service 
b/debian/quassel-core.quasselcore.service
index 1bb9910..9465575 100644
--- a/debian/quassel-core.quasselcore.service
+++ b/debian/quassel-core.quasselcore.service
@@ -10,7 +10,7 @@ Group=quassel
 WorkingDirectory=/var/lib/quassel
 Environment="DATADIR=/var/lib/quassel" "LOGFILE=/var/log/quassel/core.log" 
"LOGLEVEL=Info" "PORT=4242" "LISTEN=::,0.0.0.0"
 EnvironmentFile=-/etc/default/quasselcore
-ExecStart=/usr/bin/quasselcore --configdir=${DATADIR} --logfile=${LOGFILE} 
--loglevel=${LOGLEVEL} --port=${PORT} --listen=${LISTEN}
+ExecStart=/usr/bin/quasselcore --configdir=${DATADIR} --logfile=${LOGFILE} 
--loglevel=${LOGLEVEL} --port=${PORT} --listen=${LISTEN} ${DAEMON_OPTS}
 Restart=on-failure
 
 [Install]