Hi,
On Mon, Jun 04, 2018 at 03:24:18PM +0100, Chris Lamb wrote:
> Hi Guido,
> 
> > > Having empathy for users who are not blessed with the minutiae of a
> > > project is really essential in providing a good user experience ;)
> > 
> > …so is having empathy with maintainers that can't guess what a user has
> > already tried and why he/she didn't find the right spot.
> 
> Heh, my comment was definitely not meant as a rebuke; far more for
> anyone following along! In this instance I also didn't want to bore
> you with the story and — at the time — I was under the impression it
> was "just" that the previously suggested change was required.
> 
> > I'm happy about a patch for this. As I wrote it's already explaind at
> > the bottom of the manpage how fetching stuff works but I'm happy to have
> > --download redirect there.
> 
> Something like the attached?

Thanks. One tiny thing. import-orig should point to the import-orig
manpage (since there's no apt: syntax). Can you fix that up, othwerwise
I'll do it.
Cheers
 -- Guido

> 
> 
> Regards,
> 
> -- 
>       ,''`.
>      : :'  :     Chris Lamb
>      `. `'`      la...@debian.org / chris-lamb.co.uk
>        `-

> diff --git a/gbp/scripts/import_dsc.py b/gbp/scripts/import_dsc.py
> index 01278b4..8cd22c0 100644
> --- a/gbp/scripts/import_dsc.py
> +++ b/gbp/scripts/import_dsc.py
> @@ -367,7 +367,7 @@ def build_parser(name):
>      parser.add_config_file_option(option_name="repo-email", 
> dest="repo_email",
>                                    choices=['DEBIAN', 'GIT'])
>      parser.add_option("--download", dest='download', action="store_true",
> -                      default=False, help="Ignored. Accepted for 
> compatibility.")
> +                      default=False, help="Ignored. Accepted for 
> compatibility; see EXAMPLES in gbp-import-dsc(1).")
>      return parser
>  
>  
> diff --git a/gbp/scripts/import_orig.py b/gbp/scripts/import_orig.py
> index ad543e6..1bb8360 100644
> --- a/gbp/scripts/import_orig.py
> +++ b/gbp/scripts/import_orig.py
> @@ -368,7 +368,7 @@ def build_parser(name):
>  
>      # Accepted for compatibility
>      parser.add_option("--download", dest='download', action="store_true",
> -                      default=False, help="Ignored. Accepted for 
> compatibility.")
> +                      default=False, help="Ignored. Accepted for 
> compatibility; see EXAMPLES in gbp-import-dsc(1).")
>      return parser
>  
>  

Reply via email to