Hello, [adding Marcelo as upstream maintainer to Cc: for the UpnpAddVirtualDir problem]
On Mon, Dec 18, 2017 at 02:26:57PM +0000, James Cowgill wrote:
> On 18/12/17 09:30, Sebastian Ramacher wrote:
> > On 2017-12-18 09:48:57, Tobias Frost wrote:
> >> Am 12. Dezember 2017 22:08:24 MEZ schrieb Sebastian Ramacher
> >> <sramac...@debian.org>:
> >>> | upnp_device.c: In function 'handle_subscription_request':
> >>> | upnp_device.c:165:12: error: dereferencing pointer to incomplete type
> >>> 'struct Upnp_Subscription_Request'
> >>> | sr_event->ServiceId, sr_event->UDN);
> >>> | ^~
> >>> | upnp_device.c: At top level:
> >>> | upnp_device.c:243:17: warning: 'struct Upnp_State_Var_Request'
> >>> declared inside parameter list will not be visible outside of this
> >>> definition or declaration
> >>> | struct Upnp_State_Var_Request *var_event) {
> >>> | ^~~~~~~~~~~~~~~~~~~~~~
> >>> | upnp_device.c: In function 'handle_var_request':
> >>> | upnp_device.c:245:18: error: dereferencing pointer to incomplete type
> >>> 'struct Upnp_State_Var_Request'
> >>> | var_event->ServiceID);
> >>> | ^~
> >>> | upnp_device.c: In function 'initialize_device':
> >>> | upnp_device.c:433:7: error: too few arguments to function
> >>> 'UpnpAddVirtualDir'
> >>> | rc = UpnpAddVirtualDir("/upnp");
> >
> > Uwe, James, can you help with that?
>
> pupnp 1.8.3 changed the signature of UpnpAddVirtualDir to allow user
> data to be associated with a virtual directory. You probably want
> something like this (untested):
>
> #if UPNP_VERSION >= 10803
> rc = UpnpAddVirtualDir("/upnp", NULL, NULL);
> #else
> rc = UpnpAddVirtualDir("/upnp");
> #endif
This is unfortunate and I wonder if that can be smoothend with a cpp
macro like
#define UpnpAddVirtualDir(a) UpnpAddVirtualDir((a), NULL, NULL)
defined in libupnp's headers. I didn't test this, maybe this results in
compiler warnings? Alternatively symbol versioning might help (if not
considered too heavy).
I wonder about the state of gmrender-resurrect and if it's still in the
way to bump libupnp-dev to the upnp-1.8 series in Debian. Tobias, please
tell if you need help here.
Best regards
Uwe
signature.asc
Description: PGP signature
