Source: altree Version: 1.3.1-5 Severity: important User: [email protected] Usertags: perl-5.28-transition Tags: patch
When rebuilding altree against perl 5.27.11, we found this problem caused by the removal of the '_quicksort' sub-pragma to sort: PERL_DL_NONLAZY=1 "/usr/bin/perl" "-MExtUtils::Command::MM" "-MTest::Harness" "-e" "undef *Test::Harness::Switches; test_harness(1, 'blib/lib', 'blib/arch')" t/*.t # Failed test 'use ALTree::Import;' # at t/ALTree.t line 9. # Tried to use 'ALTree::Import'. # Error: sort: unknown subpragma '_quicksort' at /<<PKGBUILDDIR>>/blib/lib/ALTree/SitePerForet.pm line 10. With the attached patch, altree builds under perl 5.27.11. This file doesn't even seem to use perl's sort function, so the change is effectively a no-op. Thanks, Dominic.
>From 792e0f374d932af390df409d61710633d60e2717 Mon Sep 17 00:00:00 2001 From: Dominic Hargreaves <[email protected]> Date: Fri, 18 May 2018 11:21:09 +0200 Subject: [PATCH] Remove unused _quicksort sub-pragma, no longer supported in Perl 5.27 --- debian/changelog | 7 +++++++ debian/patches/no-quicksort.patch | 15 +++++++++++++++ debian/patches/series | 1 + 3 files changed, 23 insertions(+) create mode 100644 debian/patches/no-quicksort.patch diff --git a/debian/changelog b/debian/changelog index ec75751..505ee30 100644 --- a/debian/changelog +++ b/debian/changelog @@ -1,3 +1,10 @@ +altree (1.3.1-5.1) UNRELEASED; urgency=medium + + * Non-maintainer upload. + * Remove unused _quicksort sub-pragma, no longer supported in Perl 5.27 + + -- Dominic Hargreaves <[email protected]> Fri, 18 May 2018 11:20:24 +0200 + altree (1.3.1-5) unstable; urgency=medium * Moved packaging from SVN to Git diff --git a/debian/patches/no-quicksort.patch b/debian/patches/no-quicksort.patch new file mode 100644 index 0000000..735d231 --- /dev/null +++ b/debian/patches/no-quicksort.patch @@ -0,0 +1,15 @@ +Author: Dominic Hargreaves <[email protected]> +Description: Remove unused _quicksort sub-pragma, no longer supported in Perl 5.27 + +diff --git a/ALTree/SitePerForet.pm b/ALTree/SitePerForet.pm +index bbfbb4d..eaf805e 100644 +--- a/ALTree/SitePerForet.pm ++++ b/ALTree/SitePerForet.pm +@@ -7,7 +7,6 @@ package ALTree::SitePerForet; + ################################################################ + + use base qw(ALTree::Base ALTree::Site); +-use sort '_quicksort'; + + sub New { # [classe] site_nb + my $class=shift; diff --git a/debian/patches/series b/debian/patches/series index f412662..ddb8d43 100644 --- a/debian/patches/series +++ b/debian/patches/series @@ -1 +1,2 @@ from-upstream-no-nested-functions.patch +no-quicksort.patch -- 2.11.0
